From patchwork Thu Jul 17 13:56:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Utkin X-Patchwork-Id: 371165 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A0364140177 for ; Thu, 17 Jul 2014 23:57:08 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933309AbaGQN4u (ORCPT ); Thu, 17 Jul 2014 09:56:50 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:59372 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932725AbaGQN4t (ORCPT ); Thu, 17 Jul 2014 09:56:49 -0400 Received: by mail-lb0-f179.google.com with SMTP id v6so1769207lbi.10 for ; Thu, 17 Jul 2014 06:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=XVynfvASpeaXd7TkNzdw8JsuVJXMXx82JMZFm8ucoHw=; b=aKadR+aRRark8oIPS1AHusDJzKWENS9+ocLhdgzQzpTScY6SWMNIQQp01Now+NNPcM icWdS3MV9Nq2Y6PQqZSbuZdQk/jlpLcafWGcr7S67WfOFflH+ul0z6Z85GfUlrjGYhcp s0vduPCBsQLWsfMtV3CnaW2eV6dGxXa5jkyZ+eq5iVNOERlAGqD0TXWyM0jX6YgnC2qK cPguBKLwtFTAHUWJUOeDhse7RP08hN5K4EAqfzrED0sccyGzC55kMKpaBEOJSBoi7CjT ChvxaAaRtKXupJ4xvl8uLWq9TXTy1mFJM+ExLVTa797DXKwaUqTC+GDG+EcwoccI3EL/ Kc9A== X-Received: by 10.112.142.136 with SMTP id rw8mr20105310lbb.63.1405605407457; Thu, 17 Jul 2014 06:56:47 -0700 (PDT) Received: from localhost.localdomain (alfa-g11.tenet.odessa.ua. [195.138.73.151]) by mx.google.com with ESMTPSA id tq7sm3580069lbb.9.2014.07.17.06.56.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jul 2014 06:56:46 -0700 (PDT) From: Andrey Utkin To: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com Cc: linville@tuxdriver.com, Andrey Utkin Subject: [PATCH 4/4] ath9k: drop negativity checks for unsigned values coming from kstrtoul() Date: Thu, 17 Jul 2014 16:56:37 +0300 Message-Id: <1405605397-13749-1-git-send-email-andrey.krieger.utkin@gmail.com> X-Mailer: git-send-email 1.8.5.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80471 Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80481 Reported-by: David Binderman Signed-off-by: Andrey Utkin --- drivers/net/wireless/ath/ath9k/debug.c | 2 +- drivers/net/wireless/ath/ath9k/spectral.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c index ce073e9..d227936 100644 --- a/drivers/net/wireless/ath/ath9k/debug.c +++ b/drivers/net/wireless/ath/ath9k/debug.c @@ -202,7 +202,7 @@ static ssize_t write_file_ani(struct file *file, if (kstrtoul(buf, 0, &ani)) return -EINVAL; - if (ani < 0 || ani > 1) + if (ani > 1) return -EINVAL; common->disable_ani = !ani; diff --git a/drivers/net/wireless/ath/ath9k/spectral.c b/drivers/net/wireless/ath/ath9k/spectral.c index 99f4de9..5fe29b9 100644 --- a/drivers/net/wireless/ath/ath9k/spectral.c +++ b/drivers/net/wireless/ath/ath9k/spectral.c @@ -313,7 +313,7 @@ static ssize_t write_file_spectral_short_repeat(struct file *file, if (kstrtoul(buf, 0, &val)) return -EINVAL; - if (val < 0 || val > 1) + if (val > 1) return -EINVAL; sc->spec_config.short_repeat = val; @@ -361,7 +361,7 @@ static ssize_t write_file_spectral_count(struct file *file, if (kstrtoul(buf, 0, &val)) return -EINVAL; - if (val < 0 || val > 255) + if (val > 255) return -EINVAL; sc->spec_config.count = val; @@ -409,7 +409,7 @@ static ssize_t write_file_spectral_period(struct file *file, if (kstrtoul(buf, 0, &val)) return -EINVAL; - if (val < 0 || val > 255) + if (val > 255) return -EINVAL; sc->spec_config.period = val; @@ -457,7 +457,7 @@ static ssize_t write_file_spectral_fft_period(struct file *file, if (kstrtoul(buf, 0, &val)) return -EINVAL; - if (val < 0 || val > 15) + if (val > 15) return -EINVAL; sc->spec_config.fft_period = val;