From patchwork Wed Jul 16 05:29:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 370591 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EA5521400D5 for ; Wed, 16 Jul 2014 15:31:28 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934183AbaGPFbK (ORCPT ); Wed, 16 Jul 2014 01:31:10 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:55013 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754973AbaGPFbI (ORCPT ); Wed, 16 Jul 2014 01:31:08 -0400 Received: by mail-pa0-f44.google.com with SMTP id eu11so645714pac.3 for ; Tue, 15 Jul 2014 22:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=N9gUxZyQRtPR31UNhuvsuV3mKTy9QATLIlaDaEM3G6A=; b=z/BH7ju/RgA5QKMntzNyniTINaw9HPr4Zv0Tk8pHj4VmH1sUjkkIga6Wqj8jqK8AN/ 9yQ33Uz1lc4x6yrCFW+eInhrjQMryjfDxVxoncdVTRv7su7volj38MZglTbgPXUcE97X 3Rwo5LmryhHO8rDcS+XuSJJJz9Zs2Wa+hck+t/kpZxJwR8OXsLUEZEmaG73clXcMMotQ VpXrKxsooBL5vQqXH0z6Icgom1J5k7D+JfDEll9MLFIuFkX1hSKVIPoWFbJCxNZgSPsy WNkaXCHSt/E+xbbcB8g+H2JkaiDMLUozR4HU6WRE6PBgIWTV+VmpwpSJoQAZSjKWraI7 xw9A== X-Received: by 10.70.37.71 with SMTP id w7mr27097482pdj.87.1405488668096; Tue, 15 Jul 2014 22:31:08 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id jb5sm15707281pbd.73.2014.07.15.22.31.05 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 15 Jul 2014 22:31:07 -0700 (PDT) From: varkabhadram@gmail.com To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, Varka Bhadram Subject: [PATCH net-next] netlink: remove bool varible Date: Wed, 16 Jul 2014 10:59:47 +0530 Message-Id: <1405488587-26119-1-git-send-email-varkabhadram@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Varka Bhadram This patch removes the bool variable 'pass'. If the swith case exist return true or return false. Signed-off-by: Varka Bhadram --- net/netlink/af_netlink.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index e8c9f97..5dd8193 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -170,7 +170,6 @@ EXPORT_SYMBOL_GPL(netlink_remove_tap); static bool netlink_filter_tap(const struct sk_buff *skb) { struct sock *sk = skb->sk; - bool pass = false; /* We take the more conservative approach and * whitelist socket protocols that may pass. @@ -184,11 +183,10 @@ static bool netlink_filter_tap(const struct sk_buff *skb) case NETLINK_FIB_LOOKUP: case NETLINK_NETFILTER: case NETLINK_GENERIC: - pass = true; - break; + return true; } - return pass; + return false; } static int __netlink_deliver_tap_skb(struct sk_buff *skb,