From patchwork Wed Jul 16 05:17:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 370590 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C78E714011B for ; Wed, 16 Jul 2014 15:19:19 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932537AbaGPFS6 (ORCPT ); Wed, 16 Jul 2014 01:18:58 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:50136 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754973AbaGPFS5 (ORCPT ); Wed, 16 Jul 2014 01:18:57 -0400 Received: by mail-pd0-f171.google.com with SMTP id z10so590111pdj.2 for ; Tue, 15 Jul 2014 22:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=XktucveJxwEeZq2kppyC06P6QsnzWZEqk/AH2Mads8U=; b=ILGvYYmQkXVvMlwrlsC61o0GmBGQp9voVnC4DL3MD50rELmiBH+y16MsZXa9XVI3LO Z9zJacc48Bl15vyvglEAEOBb/Kp5plKHAqMRn5TfurMCm4Xtclh1EjSLCIulFM30CC2Q JHd7fVokim3ZOJ2fdufE0aSAX8N9CwcS71r5QRrQ3Td7HefbeNw2FD7pXjk+WioIUEps GpE6XgYFedu7WE3woQ7hjLxDlwA5TkJWOi1BchvGdFYBvTMbwrYj//8fJyyBKs8EwluH rsSzBZk3JuBdH2J7OKhe04DIFS/OIhAUFgz/kaU++QuWJOV+xI03Cl3QoeZKCaK08R/x C49A== X-Received: by 10.70.90.207 with SMTP id by15mr27323870pdb.31.1405487936476; Tue, 15 Jul 2014 22:18:56 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id uj2sm66122610pab.14.2014.07.15.22.18.54 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 15 Jul 2014 22:18:55 -0700 (PDT) From: varkabhadram@gmail.com To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, Varka Bhadram Subject: [PATCH net-next] netlink: fix in netlink_filter_tap Date: Wed, 16 Jul 2014 10:47:24 +0530 Message-Id: <1405487844-25969-1-git-send-email-varkabhadram@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Varka Bhadram Remove the bool variable 'pass'. Return the true/false directly. Signed-off-by: Varka Bhadram --- net/netlink/af_netlink.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index e8c9f97..5dd8193 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -170,7 +170,6 @@ EXPORT_SYMBOL_GPL(netlink_remove_tap); static bool netlink_filter_tap(const struct sk_buff *skb) { struct sock *sk = skb->sk; - bool pass = false; /* We take the more conservative approach and * whitelist socket protocols that may pass. @@ -184,11 +183,10 @@ static bool netlink_filter_tap(const struct sk_buff *skb) case NETLINK_FIB_LOOKUP: case NETLINK_NETFILTER: case NETLINK_GENERIC: - pass = true; - break; + return true; } - return pass; + return false; } static int __netlink_deliver_tap_skb(struct sk_buff *skb,