From patchwork Tue Jul 15 19:17:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anish Bhatt X-Patchwork-Id: 370121 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1452B14011B for ; Wed, 16 Jul 2014 05:17:35 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933182AbaGOTRb (ORCPT ); Tue, 15 Jul 2014 15:17:31 -0400 Received: from 99-65-72-227.uvs.sntcca.sbcglobal.net ([99.65.72.227]:35449 "EHLO stargate3.asicdesigners.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933003AbaGOTRa (ORCPT ); Tue, 15 Jul 2014 15:17:30 -0400 Received: from cerveza.asicdesigners.com (cerveza.asicdesigners.com [10.192.164.225]) by stargate3.asicdesigners.com (8.13.8/8.13.8) with ESMTP id s6FJHOdF012105; Tue, 15 Jul 2014 12:17:24 -0700 From: Anish Bhatt To: netdev@vger.kernel.org Cc: davem@davemloft.net, leedom@chelsio.com, hariprasad@chelsio.com, dan.carpenter@oracle.com, Anish Bhatt Subject: [PATCH net-next] cxgb4: Fix static checker warnings Date: Tue, 15 Jul 2014 12:17:23 -0700 Message-Id: <1405451843-3081-1-git-send-email-anish@chelsio.com> X-Mailer: git-send-email 2.0.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch fixes static checker warnings as pointed out on by Dan Carpenter Fixes: 76bcb31efc06 ("cxgb4 : Add DCBx support codebase and dcbnl_ops") Signed-off-by: Anish Bhatt --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c index a8b1073e6373..8734dfe0da32 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c @@ -676,15 +676,15 @@ static u8 cxgb4_setapp(struct net_device *dev, u8 app_idtype, u16 app_id, if (pi->dcb.state != CXGB4_DCB_STATE_FW_ALLSYNCED) - return -EINVAL; + return 0; /* DCB info gets thrown away on link up */ if (!netif_carrier_ok(dev)) - return -ENOLINK; + return 0; if (app_idtype != DCB_APP_IDTYPE_ETHTYPE && app_idtype != DCB_APP_IDTYPE_PORTNUM) - return -EINVAL; + return 0; for (i = 0; i < CXGB4_MAX_DCBX_APP_SUPPORTED; i++) { INIT_PORT_DCB_READ_LOCAL_CMD(pcmd, pi->port_id); @@ -710,7 +710,7 @@ static u8 cxgb4_setapp(struct net_device *dev, u8 app_idtype, u16 app_id, if (i == CXGB4_MAX_DCBX_APP_SUPPORTED) { /* no empty slots available */ dev_err(adap->pdev_dev, "DCB app table full\n"); - return -EBUSY; + return 0; } /* write out new app table entry */