From patchwork Mon Jul 14 06:25:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 369507 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 00D75140093 for ; Mon, 14 Jul 2014 16:28:49 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753087AbaGNG2B (ORCPT ); Mon, 14 Jul 2014 02:28:01 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:65251 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752688AbaGNG1i (ORCPT ); Mon, 14 Jul 2014 02:27:38 -0400 Received: by mail-pd0-f179.google.com with SMTP id w10so4657828pde.38 for ; Sun, 13 Jul 2014 23:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ZjtzM7pe8IyltTznR1h+0EkIfY7Zfr7gEXyxGES6kU0=; b=JvbcniiL94nnnvIfnb/8sbVw8K5lC11o7Sh+b1pJOzKrPgawWDDHn+hKA0LUIcV4aL f9d3Fe6ClYKgEbXMqdztKui1xvw203ghb7yp7fOs6hfugctjNkbdmllu9RLtss+XhF4I VohUKaTg1bex7NH1uBLZ5PNLWUm86RsBeX6lk2+zPuiMJfcyZMdOtPZkDyBjQx8LI7QI +FANBiiqjS+M30tm5MYZESIS0GlE/bgkOQSI58hHyepCarYVFNVG3wLhU9/HydpScJRo AbNU7WHmbxEvwX/B5F5Kvyy7LTVUjg5uLvXVrtzX7QQOjnLqxsCPCy5P6ktzUDUfoszd x13Q== X-Received: by 10.66.182.132 with SMTP id ee4mr15562269pac.64.1405319257431; Sun, 13 Jul 2014 23:27:37 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id g7sm13014708pdk.87.2014.07.13.23.27.34 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 13 Jul 2014 23:27:36 -0700 (PDT) From: varkabhadram@gmail.com To: netdev@vger.kernel.org Cc: Thomas.Lendacky@amd.com, geert+renesas@linux-m68k.org, ebiederm@xmission.com, macro@linux-mips.org, linux-kernel@vger.kernel.org, davem@davemloft.net, Varka Bhadram Subject: [PATCH net-next v2 1/6] ethernet: amd: move amd111e_remove_one after probe Date: Mon, 14 Jul 2014 11:55:42 +0530 Message-Id: <1405319147-5212-2-git-send-email-varkabhadram@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1405319147-5212-1-git-send-email-varkabhadram@gmail.com> References: <1405319147-5212-1-git-send-email-varkabhadram@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Varka Bhadram This patch moves the remove functionalities after the probe so that we can see the registered and released resources properly. Every driver follows the same concept. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/amd/amd8111e.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/amd/amd8111e.c b/drivers/net/ethernet/amd/amd8111e.c index 068dc7c..ddd09e8 100644 --- a/drivers/net/ethernet/amd/amd8111e.c +++ b/drivers/net/ethernet/amd/amd8111e.c @@ -1701,18 +1701,6 @@ static int amd8111e_resume(struct pci_dev *pci_dev) return 0; } - -static void amd8111e_remove_one(struct pci_dev *pdev) -{ - struct net_device *dev = pci_get_drvdata(pdev); - if (dev) { - unregister_netdev(dev); - iounmap(((struct amd8111e_priv *)netdev_priv(dev))->mmio); - free_netdev(dev); - pci_release_regions(pdev); - pci_disable_device(pdev); - } -} static void amd8111e_config_ipg(struct net_device* dev) { struct amd8111e_priv *lp = netdev_priv(dev); @@ -1970,6 +1958,19 @@ err_disable_pdev: } +static void amd8111e_remove_one(struct pci_dev *pdev) +{ + struct net_device *dev = pci_get_drvdata(pdev); + + if (dev) { + unregister_netdev(dev); + iounmap(((struct amd8111e_priv *)netdev_priv(dev))->mmio); + free_netdev(dev); + pci_release_regions(pdev); + pci_disable_device(pdev); + } +} + static struct pci_driver amd8111e_driver = { .name = MODULE_NAME, .id_table = amd8111e_pci_tbl,