From patchwork Fri Jul 11 07:35:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 369033 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E2D081400DD for ; Fri, 11 Jul 2014 17:44:57 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752862AbaGKHgo (ORCPT ); Fri, 11 Jul 2014 03:36:44 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:52712 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbaGKHgk (ORCPT ); Fri, 11 Jul 2014 03:36:40 -0400 Received: by mail-pd0-f180.google.com with SMTP id fp1so933589pdb.25 for ; Fri, 11 Jul 2014 00:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FlXeVZ+Jt36urvc812/XYnzmYtrSzRABor/w5mZOpKw=; b=0o0/bE08U9Rsi087OmrLkNEtW6VP/ifo/zQSrdeeFSvOsOLXEUr1o4z1qJVtodK23Y SkYxx7NXrAQvnLq19slzAEECD9DJ+3nbpMPVipIWm/8+oMi3ZZNxjjgd46jrn5Lq3Fep hIfFyR4c3mtQJqB5AyuhaFiZ0UTFxtbiEE//OUMF6MerKUn1w8Bvq/ca71AkVblm1lso YxMMP1fMn5vv7Ta8A1ReU+lJpXQTSaF2An9xV1K4ofG7Ex+AqWRzxGdZEaRPuOWJdACC Teey4TM+wrsywnDpP2LLlQ1JNAly+pIpK5165DU03Qpgmy/6Q2obNNkauBb0PLyD7W/x vyzQ== X-Received: by 10.66.180.34 with SMTP id dl2mr8273185pac.124.1405064200233; Fri, 11 Jul 2014 00:36:40 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id v5sm1902490pdc.7.2014.07.11.00.36.37 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 11 Jul 2014 00:36:39 -0700 (PDT) From: varkabhadram@gmail.com To: netdev@vger.kernel.org Cc: Thomas.Lendacky@amd.com, geert+renesas@linux-m68k.org, ebiederm@xmission.com, macro@linux-mips.org, linux-kernel@vger.kernel.org, davem@davemloft.net, Varka Bhadram Subject: [PATCH net-next 2/8] ethernet: amd: use devm_ioremap() Date: Fri, 11 Jul 2014 13:05:04 +0530 Message-Id: <1405064110-22579-3-git-send-email-varkabhadram@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1405064110-22579-1-git-send-email-varkabhadram@gmail.com> References: <1405064110-22579-1-git-send-email-varkabhadram@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Varka Bhadram This patch replace ioremap() with the devm_ioremap() so that the resource will be freed automatically with the probe failed. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/amd/amd8111e.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/amd/amd8111e.c b/drivers/net/ethernet/amd/amd8111e.c index ddd09e8..433107c 100644 --- a/drivers/net/ethernet/amd/amd8111e.c +++ b/drivers/net/ethernet/amd/amd8111e.c @@ -1866,7 +1866,7 @@ static int amd8111e_probe_one(struct pci_dev *pdev, spin_lock_init(&lp->lock); - lp->mmio = ioremap(reg_addr, reg_len); + lp->mmio = devm_ioremap(&pdev->dev, reg_addr, reg_len); if (!lp->mmio) { printk(KERN_ERR "amd8111e: Cannot map device registers, " "exiting\n"); @@ -1913,7 +1913,7 @@ static int amd8111e_probe_one(struct pci_dev *pdev, if (err) { printk(KERN_ERR "amd8111e: Cannot register net device, " "exiting.\n"); - goto err_iounmap; + goto err_free_dev; } pci_set_drvdata(pdev, dev); @@ -1943,8 +1943,6 @@ static int amd8111e_probe_one(struct pci_dev *pdev, printk(KERN_INFO "%s: Couldn't detect MII PHY, assuming address 0x01\n", dev->name); return 0; -err_iounmap: - iounmap(lp->mmio); err_free_dev: free_netdev(dev); @@ -1964,7 +1962,6 @@ static void amd8111e_remove_one(struct pci_dev *pdev) if (dev) { unregister_netdev(dev); - iounmap(((struct amd8111e_priv *)netdev_priv(dev))->mmio); free_netdev(dev); pci_release_regions(pdev); pci_disable_device(pdev);