From patchwork Thu Jul 10 09:59:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 368552 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C29EF140144 for ; Thu, 10 Jul 2014 20:01:11 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbaGJKBE (ORCPT ); Thu, 10 Jul 2014 06:01:04 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:38443 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752926AbaGJKBD (ORCPT ); Thu, 10 Jul 2014 06:01:03 -0400 Received: by mail-pa0-f44.google.com with SMTP id rd3so10846042pab.17 for ; Thu, 10 Jul 2014 03:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=ehXChg85e6WJtwLrsDNGgebpmFV46Ex6rNlF76Sxb5I=; b=07lCgctUzDlcSy3lwcdaIV5Thkyxw1dvotg0IX7qcwk7EoZZIy7kuft67Z5g6wg4B1 dADy3tmKzrtxGb3XmtoWpFO/Ovkg8x2Pn86l2EZqkXcQTaommclgWNlyWhuF7opdRyse 10mrU7p7AQukUKtAUhqnjCFXOxGrQYIwL+XYkfMxMYhr9pinsPIRWkaGqBVPWV0g+0RF MGgrpJqK8xHzSn8GQhJSCCyYqNxsUUzrtj+GzjQw+r7zcDWmE9vRPa2dpEjh9OOjF929 /Bh14RjGCFpgFgFpLgGUEmEfoGArwRRyHMgM5uJVD3mtxsmJMQc572f77ndp2Q9PSADN uLBQ== X-Received: by 10.66.178.172 with SMTP id cz12mr956230pac.133.1404986463144; Thu, 10 Jul 2014 03:01:03 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id iq10sm61449010pbc.14.2014.07.10.03.01.00 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 10 Jul 2014 03:01:02 -0700 (PDT) From: varkabhadram@gmail.com To: netdev@vger.kernel.org Cc: mugunthanvnm@ti.com, linux@rainbow-software.org, balbi@ti.com, george.cherian@ti.com, davem@davemloft.net, Varka Bhadram Subject: [PATCH net-next] net: cpmac: fix in debug messages Date: Thu, 10 Jul 2014 15:29:38 +0530 Message-Id: <1404986378-28555-1-git-send-email-varkabhadram@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Varka Bhadram This patch fix the debug message format. This patch changes to the commit f160a2d0b524eeebd97a68e2fbb59fad4cdd3fee: net: cpmac: dynamic debug fixes When we use pr_debug()/netdev_dbg() new lines are inserting in b/w the values. The format when i use the printk() These formats used in skb dump and reg dump. This functions called from the entire code. So this will be enabled all the lines. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/ti/cpmac.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/ti/cpmac.c b/drivers/net/ethernet/ti/cpmac.c index b68c5b5..3809f4e 100644 --- a/drivers/net/ethernet/ti/cpmac.c +++ b/drivers/net/ethernet/ti/cpmac.c @@ -228,22 +228,22 @@ static void cpmac_dump_regs(struct net_device *dev) for (i = 0; i < CPMAC_REG_END; i += 4) { if (i % 16 == 0) { if (i) - pr_cont("\n"); - netdev_dbg(dev, "reg[%p]:", priv->regs + i); + printk("\n"); + printk("%s: reg[%p]:", dev->name, priv->regs + i); } - pr_debug(" %08x", cpmac_read(priv->regs, i)); + printk(" %08x", cpmac_read(priv->regs, i)); } - pr_debug("\n"); + printk("\n"); } static void cpmac_dump_desc(struct net_device *dev, struct cpmac_desc *desc) { int i; - netdev_dbg(dev, "desc[%p]:", desc); + printk("%s: desc[%p]:", dev->name, desc); for (i = 0; i < sizeof(*desc) / 4; i++) - pr_debug(" %08x", ((u32 *)desc)[i]); - pr_debug("\n"); + printk(" %08x", ((u32 *)desc)[i]); + printk("\n"); } static void cpmac_dump_all_desc(struct net_device *dev) @@ -261,16 +261,16 @@ static void cpmac_dump_skb(struct net_device *dev, struct sk_buff *skb) { int i; - netdev_dbg(dev, "skb 0x%p, len=%d\n", skb, skb->len); + printk("%s: skb 0x%p, len=%d\n", dev->name, skb, skb->len); for (i = 0; i < skb->len; i++) { if (i % 16 == 0) { if (i) - pr_cont("\n"); - netdev_dbg(dev, "data[%p]:", skb->data + i); + printk("\n"); + printk("%s: data[%p]:", dev->name, skb->data + i); } - pr_debug(" %02x", ((u8 *)skb->data)[i]); + printk(" %02x", ((u8 *)skb->data)[i]); } - pr_debug("\n"); + printk("\n"); } static int cpmac_mdio_read(struct mii_bus *bus, int phy_id, int reg)