From patchwork Wed Jul 2 22:20:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Aring X-Patchwork-Id: 366500 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 07F871400B7 for ; Thu, 3 Jul 2014 08:22:09 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757831AbaGBWVl (ORCPT ); Wed, 2 Jul 2014 18:21:41 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:36658 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756577AbaGBWVj (ORCPT ); Wed, 2 Jul 2014 18:21:39 -0400 Received: by mail-wi0-f181.google.com with SMTP id n3so1299301wiv.8 for ; Wed, 02 Jul 2014 15:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1g+a2pA2XmsLpLIeuoMs9qK7CsyZ6XqzmKT6oyQxwC0=; b=RXNL0AYTZ9cUqENH7wEwIVpqOZNygzPLw4zZIT22HKOy1jVMlydi7KCXF5B8V/SrR3 uBMophqEKLSS/mTJWxQuwP6phLaEyezlWR+N1x8oa0LsvVgULHQryKQ21udRfIBJXBD6 i51vlwEzKf4/zjxHGCIMdrhPhKQAtvJHERFnOoKypq+tg1lwRYzDmU8ryhRthtdOUbn7 xA5evn+YU4oT3c6kpCmR4wm5XTBzJFLuqhc21kG20CyooHb9XRcyliGO/YsB0bvYVP+Z AKZTka1Wx+335Z4VqqYkF3wO6JGRJNeVFAuMxy5eRh/EswDAiavnFlVUBSl1zOcX4zzd yMfA== X-Received: by 10.194.90.51 with SMTP id bt19mr515633wjb.105.1404339698436; Wed, 02 Jul 2014 15:21:38 -0700 (PDT) Received: from omega.localdomain (p4FD3BDAF.dip0.t-ipconnect.de. [79.211.189.175]) by mx.google.com with ESMTPSA id a13sm57797875wjs.12.2014.07.02.15.21.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Jul 2014 15:21:37 -0700 (PDT) From: Alexander Aring To: alex.bluesman.smirnov@gmail.com Cc: dbaryshkov@gmail.com, linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org, stilwellt@openlabs.co, Alexander Aring Subject: [PATCH v3 net-next 07/13] at86rf230: move RX_SAFE_MODE setting to hw_init Date: Thu, 3 Jul 2014 00:20:49 +0200 Message-Id: <1404339655-8456-8-git-send-email-alex.aring@gmail.com> X-Mailer: git-send-email 2.0.1 In-Reply-To: <1404339655-8456-1-git-send-email-alex.aring@gmail.com> References: <1404339655-8456-1-git-send-email-alex.aring@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is no need to set this bit in start callback which could be called more than once. Signed-off-by: Alexander Aring --- drivers/net/ieee802154/at86rf230.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c index 39c3c11..492fb7e 100644 --- a/drivers/net/ieee802154/at86rf230.c +++ b/drivers/net/ieee802154/at86rf230.c @@ -1010,13 +1010,8 @@ err: static int at86rf230_start(struct ieee802154_dev *dev) { - struct at86rf230_local *lp = dev->priv; u8 rc; - rc = at86rf230_write_subreg(lp, SR_RX_SAFE_MODE, 1); - if (rc) - return rc; - rc = at86rf230_state(dev, STATE_TX_ON); if (rc) return rc; @@ -1300,6 +1295,10 @@ static int at86rf230_hw_init(struct at86rf230_local *lp) if (rc) return rc; + rc = at86rf230_write_subreg(lp, SR_RX_SAFE_MODE, 1); + if (rc) + return rc; + rc = at86rf230_write_subreg(lp, SR_IRQ_MASK, IRQ_TRX_END); if (rc) return rc;