From patchwork Thu Jun 5 08:53:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 356235 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BAC4614009C for ; Thu, 5 Jun 2014 18:55:15 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751762AbaFEIzK (ORCPT ); Thu, 5 Jun 2014 04:55:10 -0400 Received: from webbox1416.server-home.net ([77.236.96.61]:42848 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751624AbaFEIyu (ORCPT ); Thu, 5 Jun 2014 04:54:50 -0400 Received: from imapserver.systec-electronic.com (unknown [212.185.67.148]) by webbox1416.server-home.net (Postfix) with ESMTPA id 9E28C27A690; Thu, 5 Jun 2014 10:42:13 +0200 (CEST) Received: from ws-stein.systec-electronic.de (unknown [192.168.10.109]) by imapserver.systec-electronic.com (Postfix) with ESMTP id 19AC4DA0C68; Thu, 5 Jun 2014 10:54:47 +0200 (CEST) From: Alexander Stein To: "David S. Miller" Cc: Daniel Krueger , netdev@vger.kernel.org, Alexander Stein Subject: [PATCH v2 6/6] pch_gbe: remove shutdown and restart of interface after PHY settings change Date: Thu, 5 Jun 2014 10:53:07 +0200 Message-Id: <1401958387-8154-6-git-send-email-alexander.stein@systec-electronic.com> X-Mailer: git-send-email 1.8.5.5 In-Reply-To: <1401958387-8154-1-git-send-email-alexander.stein@systec-electronic.com> References: <1401958387-8154-1-git-send-email-alexander.stein@systec-electronic.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Daniel Krueger This is not necessary. mii_ethtool_sset retriggers the autonegociation if necessary automatically. Signed-off-by: Daniel Krueger Signed-off-by: Alexander Stein --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c index fbfac98..2284042 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c @@ -128,13 +128,6 @@ static int pch_gbe_set_settings(struct net_device *netdev, hw->phy.autoneg_advertised = ecmd->advertising; hw->mac.autoneg = ecmd->autoneg; - /* reset the link */ - if (netif_running(adapter->netdev)) { - pch_gbe_down(adapter); - ret = pch_gbe_up(adapter); - } else { - pch_gbe_reset(adapter); - } return ret; }