| Message ID | 1401726302-21240-1-git-send-email-mschmidt@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Michal Schmidt <mschmidt@redhat.com> Date: Mon, 2 Jun 2014 18:25:02 +0200 > Any process is able to send netlink messages with leftover bytes. > Make the warning rate-limited to prevent too much log spam. > > The warning is supposed to help find userspace bugs, so print the > triggering command name to implicate the buggy program. > > [v2: Use pr_warn_ratelimited instead of printk_ratelimited.] > > Signed-off-by: Michal Schmidt <mschmidt@redhat.com> Applied, thanks Michal. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/lib/nlattr.c b/lib/nlattr.c index fc67547..10ad042 100644 --- a/lib/nlattr.c +++ b/lib/nlattr.c @@ -201,8 +201,8 @@ int nla_parse(struct nlattr **tb, int maxtype, const struct nlattr *head, } if (unlikely(rem > 0)) - printk(KERN_WARNING "netlink: %d bytes leftover after parsing " - "attributes.\n", rem); + pr_warn_ratelimited("netlink: %d bytes leftover after parsing attributes in process `%s'.\n", + rem, current->comm); err = 0; errout:
Any process is able to send netlink messages with leftover bytes. Make the warning rate-limited to prevent too much log spam. The warning is supposed to help find userspace bugs, so print the triggering command name to implicate the buggy program. [v2: Use pr_warn_ratelimited instead of printk_ratelimited.] Signed-off-by: Michal Schmidt <mschmidt@redhat.com> --- lib/nlattr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)