From patchwork Fri May 30 13:56:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Dooks X-Patchwork-Id: 354188 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5215F14008B for ; Fri, 30 May 2014 23:56:39 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933212AbaE3N4f (ORCPT ); Fri, 30 May 2014 09:56:35 -0400 Received: from ducie-dc1.codethink.co.uk ([185.25.241.215]:33449 "EHLO ducie-dc1.codethink.co.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932162AbaE3N4e (ORCPT ); Fri, 30 May 2014 09:56:34 -0400 Received: from localhost (localhost [127.0.0.1]) by ducie-dc1.codethink.co.uk (Postfix) with ESMTP id 6AF564667BE; Fri, 30 May 2014 14:56:32 +0100 (BST) X-Virus-Scanned: Debian amavisd-new at ducie-dc1.codethink.co.uk Received: from ducie-dc1.codethink.co.uk ([127.0.0.1]) by localhost (ducie-dc1.codethink.co.uk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LnKSILrx9DGT; Fri, 30 May 2014 14:56:28 +0100 (BST) Received: from rainbowdash.ducie.codethink.co.uk (rainbowdash.dyn.ducie.codethink.co.uk [10.24.1.179]) by ducie-dc1.codethink.co.uk (Postfix) with ESMTPS id 6460F4613F1; Fri, 30 May 2014 14:56:28 +0100 (BST) Received: from ben by rainbowdash.ducie.codethink.co.uk with local (Exim 4.82) (envelope-from ) id 1WqNIK-0007oD-01; Fri, 30 May 2014 14:56:28 +0100 From: Ben Dooks To: netdev@vger.kernel.org Cc: linux-kernel@codethink.co.uk, Ben Dooks , nobuhiro.iwamatsu.yj@renesas.com, magnus.damn@opensource.se, horms@verge.net.au Subject: [PATCH] sh_eth: use RNC mode for R8A7790 Date: Fri, 30 May 2014 14:56:26 +0100 Message-Id: <1401458186-29985-1-git-send-email-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 2.0.0.rc2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The current behaviour of the sh_eth driver is not to use the RNC bit for the receive ring. This means that every packet recieved is not only generating an IRQ but it also stops the receive ring DMA as well until the driver re-enables it after unloading the packet. This means that a number of the following errors are generated due to the receive packet FIFO overflowing due to nowhere to put packets: net eth0: Receive FIFO Overflow Setting the RMCR_RNC configuration has so far been tested with an NFS root filesystem and the driver has not failed yet. It is not yet known why this is not set for R8A779x operation (Feedback on this issue or other testing is welcome) There are further test reports from Sergei Shtylov and others for both the R8A7790 and R8A7791. Tested-by: Sergei Shtylyov Signed-off-by: Ben Dooks Acked-by: Sergei Shtylyov --- Cc: nobuhiro.iwamatsu.yj@renesas.com Cc: magnus.damn@opensource.se Cc: horms@verge.net.au --- drivers/net/ethernet/renesas/sh_eth.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 6a9509c..1e3e5d2 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -468,6 +468,7 @@ static struct sh_eth_cpu_data r8a779x_data = { .ecsr_value = ECSR_PSRTO | ECSR_LCHNG | ECSR_ICD, .ecsipr_value = ECSIPR_PSRTOIP | ECSIPR_LCHNGIP | ECSIPR_ICDIP, .eesipr_value = 0x01ff009f, + .rmcr_value = RMCR_RNC, .tx_check = EESR_FTC | EESR_CND | EESR_DLC | EESR_CD | EESR_RTO, .eesr_err_check = EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE |