From patchwork Sun May 25 14:55:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajesh Borundia X-Patchwork-Id: 352249 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2D7C7140086 for ; Mon, 26 May 2014 01:24:39 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751401AbaEYPYc (ORCPT ); Sun, 25 May 2014 11:24:32 -0400 Received: from mx0b-0016ce01.pphosted.com ([67.231.156.153]:1239 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbaEYPYb (ORCPT ); Sun, 25 May 2014 11:24:31 -0400 Received: from pps.filterd (m0000643.ppops.net [127.0.0.1]) by mx0b-0016ce01.pphosted.com (8.14.5/8.14.5) with SMTP id s4PFOTgJ025262; Sun, 25 May 2014 08:24:29 -0700 Received: from avcashub1.qlogic.com (avcashub2.qlogic.com [198.70.193.116]) by mx0b-0016ce01.pphosted.com with ESMTP id 1kurt205gb-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sun, 25 May 2014 08:24:28 -0700 Received: from dut6217.mv.qlogic.com (172.29.56.217) by qlc.com (10.1.4.191) with Microsoft SMTP Server id 14.2.347.0; Sun, 25 May 2014 08:24:26 -0700 Received: by dut6217.mv.qlogic.com (Postfix, from userid 0) id 967155221DB; Sun, 25 May 2014 10:55:05 -0400 (EDT) From: Rajesh Borundia To: CC: , Subject: [PATCH net] qlcnic: Initialize mailbox cmd structure to zero. Date: Sun, 25 May 2014 10:55:02 -0400 Message-ID: <1401029702-22267-1-git-send-email-rajesh.borundia@qlogic.com> X-Mailer: git-send-email 1.7.7 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5600 definitions=7448 signatures=670454 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1405250214 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org o Uninitialized fields in mailbox command structure caused commands to time out randomly due to garbage values, so initialize it to zero. Signed-off-by: Rajesh Borundia --- .../ethernet/qlogic/qlcnic/qlcnic_sriov_common.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c index 6afe9c1..15f4c9e 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c @@ -702,6 +702,7 @@ static int qlcnic_sriov_alloc_bc_mbx_args(struct qlcnic_cmd_args *mbx, u32 type) const struct qlcnic_mailbox_metadata *mbx_tbl; int i, size; + memset(mbx, 0, sizeof(*mbx)); mbx_tbl = qlcnic_sriov_bc_mbx_tbl; size = ARRAY_SIZE(qlcnic_sriov_bc_mbx_tbl);