From patchwork Thu Feb 9 07:27:58 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajesh Borundia X-Patchwork-Id: 140321 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 08C1EB6F62 for ; Thu, 9 Feb 2012 18:28:38 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753859Ab2BIH2f (ORCPT ); Thu, 9 Feb 2012 02:28:35 -0500 Received: from am1ehsobe006.messaging.microsoft.com ([213.199.154.209]:12722 "EHLO AM1EHSOBE003.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751621Ab2BIH2e convert rfc822-to-8bit (ORCPT ); Thu, 9 Feb 2012 02:28:34 -0500 Received: from mail38-am1-R.bigfish.com (10.3.201.228) by AM1EHSOBE003.bigfish.com (10.3.204.23) with Microsoft SMTP Server id 14.1.225.23; Thu, 9 Feb 2012 07:28:33 +0000 Received: from mail38-am1 (localhost [127.0.0.1]) by mail38-am1-R.bigfish.com (Postfix) with ESMTP id 94CC04E0122; Thu, 9 Feb 2012 07:28:32 +0000 (UTC) X-SpamScore: 0 X-BigFish: VPS0(zz9371Izz1202hzz8275bh8275dhz2ei2a8h668h839h944h) X-Forefront-Antispam-Report: CIP:198.70.193.64; KIP:(null); UIP:(null); IPV:NLI; H:avexcashub1.qlogic.com; RD:avexcashub2.qlogic.com; EFVD:NLI Received-SPF: neutral (mail38-am1: 198.70.193.64 is neither permitted nor denied by domain of qlogic.com) client-ip=198.70.193.64; envelope-from=rajesh.borundia@qlogic.com; helo=avexcashub1.qlogic.com ; 1.qlogic.com ; Received: from mail38-am1 (localhost.localdomain [127.0.0.1]) by mail38-am1 (MessageSwitch) id 1328772510355587_3526; Thu, 9 Feb 2012 07:28:30 +0000 (UTC) Received: from AM1EHSMHS017.bigfish.com (unknown [10.3.201.238]) by mail38-am1.bigfish.com (Postfix) with ESMTP id 4D1811C0047; Thu, 9 Feb 2012 07:28:30 +0000 (UTC) Received: from avexcashub1.qlogic.com (198.70.193.64) by AM1EHSMHS017.bigfish.com (10.3.207.155) with Microsoft SMTP Server (TLS) id 14.1.225.23; Thu, 9 Feb 2012 07:28:23 +0000 Received: from MNEXCASHUB2.qlogic.org (10.33.2.104) by avexcashub2.qlogic.org (10.1.4.162) with Microsoft SMTP Server (TLS) id 8.3.192.1; Wed, 8 Feb 2012 23:28:21 -0800 Received: from MNEXMB1.qlogic.org ([fe80::8516:7839:9549:6996]) by MNEXCASHUB2.qlogic.org ([::1]) with mapi; Thu, 9 Feb 2012 01:28:19 -0600 From: Rajesh Borundia To: Dan Carpenter , Sony Chacko CC: netdev , "kernel-janitors@vger.kernel.org" Date: Thu, 9 Feb 2012 01:27:58 -0600 Subject: RE: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk() Thread-Topic: [patch] netxen_nic: signedness bug in netxen_md_entry_err_chk() Thread-Index: AczmQ16NE2zqSUIOS1mBGUHyi8y3BQAuPpn2 Message-ID: <13A253B3F9BEFE43B93C09CF75F63CAA81A886ECD2@MNEXMB1.qlogic.org> References: <20120208092335.GC6554@elgon.mountain> In-Reply-To: <20120208092335.GC6554@elgon.mountain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-OriginatorOrg: qlogic.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thanks Dan for fixing this. Rajesh diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c index 0a81228..6f37470 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c @@ -2354,7 +2354,7 @@ netxen_md_rdqueue(struct netxen_adapter *adapter, */ static int netxen_md_entry_err_chk(struct netxen_adapter *adapter, - struct netxen_minidump_entry *entry, u32 esize) + struct netxen_minidump_entry *entry, int esize) { if (esize < 0) { entry->hdr.driver_flags |= NX_DUMP_SKIP;