diff mbox

cpts: Fix missing includes

Message ID 1396805660-9807-1-git-send-email-vincent.stehle@laposte.net
State Not Applicable, archived
Delegated to: David Miller
Headers show

Commit Message

Vincent Stehlé April 6, 2014, 5:34 p.m. UTC
The ETH_HLEN and VLAN_HLEN definitions are not in if.h any more. Add the
necessary includes to fix the following compilation errors:

  drivers/net/ethernet/ti/cpts.c: In function ‘cpts_match’:
  drivers/net/ethernet/ti/cpts.c:266:12: error: ‘ETH_HLEN’ undeclared (first use in this function)
  drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
  drivers/net/ethernet/ti/cpts.c:276:23: error: ‘VLAN_HLEN’ undeclared (first use in this function)

Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
---


Hi,

This compilation error can be seen with e.g. arm allmodconfig.

Best regards,

V.


 drivers/net/ethernet/ti/cpts.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Daniel Borkmann April 6, 2014, 5:47 p.m. UTC | #1
On 04/06/2014 07:34 PM, Vincent Stehlé wrote:
> The ETH_HLEN and VLAN_HLEN definitions are not in if.h any more. Add the
> necessary includes to fix the following compilation errors:
>
>    drivers/net/ethernet/ti/cpts.c: In function ‘cpts_match’:
>    drivers/net/ethernet/ti/cpts.c:266:12: error: ‘ETH_HLEN’ undeclared (first use in this function)
>    drivers/net/ethernet/ti/cpts.c:266:12: note: each undeclared identifier is reported only once for each function it appears in
>    drivers/net/ethernet/ti/cpts.c:276:23: error: ‘VLAN_HLEN’ undeclared (first use in this function)
>
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>

Thanks, fix is already in net tree ...

https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=79eb9d28c9b22fa419e2c3f1b2cc6e285720ae41

> diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
> index a3bbf59..2a2f82a 100644
> --- a/drivers/net/ethernet/ti/cpts.c
> +++ b/drivers/net/ethernet/ti/cpts.c
> @@ -19,6 +19,8 @@
>    */
>   #include <linux/err.h>
>   #include <linux/if.h>
> +#include <linux/if_ether.h>
> +#include <linux/if_vlan.h>
>   #include <linux/hrtimer.h>
>   #include <linux/module.h>
>   #include <linux/net_tstamp.h>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/ti/cpts.c b/drivers/net/ethernet/ti/cpts.c
index a3bbf59..2a2f82a 100644
--- a/drivers/net/ethernet/ti/cpts.c
+++ b/drivers/net/ethernet/ti/cpts.c
@@ -19,6 +19,8 @@ 
  */
 #include <linux/err.h>
 #include <linux/if.h>
+#include <linux/if_ether.h>
+#include <linux/if_vlan.h>
 #include <linux/hrtimer.h>
 #include <linux/module.h>
 #include <linux/net_tstamp.h>