From patchwork Mon Feb 17 15:28:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Dooks X-Patchwork-Id: 321042 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7D8AC2C00C8 for ; Tue, 18 Feb 2014 02:28:30 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753923AbaBQP2Z (ORCPT ); Mon, 17 Feb 2014 10:28:25 -0500 Received: from 82-68-191-81.dsl.posilan.com ([82.68.191.81]:59727 "EHLO rainbowdash.ducie.codethink.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753688AbaBQP2Y (ORCPT ); Mon, 17 Feb 2014 10:28:24 -0500 Received: from ben by rainbowdash.ducie.codethink.co.uk with local (Exim 4.82) (envelope-from ) id 1WFQ7E-0000NV-Rr; Mon, 17 Feb 2014 15:28:16 +0000 From: Ben Dooks To: netdev@vger.kernel.org Cc: horms+renesas@verge.net.au, sergei.shtylyov@cogentembedded.com, linux-sh@vger.kernel.org, magnus@opensource.se, linux-kernel@lists.codethink.co.uk, Ben Dooks Subject: [PATCH] sh_eth: call of_mdiobus_register() to register phys Date: Mon, 17 Feb 2014 15:28:15 +0000 Message-Id: <1392650895-1422-1-git-send-email-ben.dooks@codethink.co.uk> X-Mailer: git-send-email 1.8.5.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org If the sh_eth device is registered using OF, then the driver should call of_mdiobus_register() to register any PHYs connected to the system. Signed-off-by: Ben Dooks --- drivers/net/ethernet/renesas/sh_eth.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 06970ac..165f0c4 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -40,6 +40,7 @@ #include #include #include +#include #include "sh_eth.h" @@ -2629,6 +2630,18 @@ static int sh_mdio_init(struct net_device *ndev, int id, snprintf(mdp->mii_bus->id, MII_BUS_ID_SIZE, "%s-%x", mdp->pdev->name, id); + if (ndev->dev.parent->of_node) { + dev_set_drvdata(&ndev->dev, mdp->mii_bus); + ret = of_mdiobus_register(mdp->mii_bus, + ndev->dev.parent->of_node); + if (ret != 0) { + dev_err(&ndev->dev, "of_mdiobus_register() failed\n"); + goto out_free_bus; + } + + return 0; + } + /* PHY IRQ */ mdp->mii_bus->irq = devm_kzalloc(&ndev->dev, sizeof(int) * PHY_MAX_ADDR,