From patchwork Tue Feb 11 14:06:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: FX Le Bail X-Patchwork-Id: 319306 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 88EDE2C008F for ; Wed, 12 Feb 2014 01:36:40 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751849AbaBKOgg (ORCPT ); Tue, 11 Feb 2014 09:36:36 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:28742 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751840AbaBKOgf (ORCPT ); Tue, 11 Feb 2014 09:36:35 -0500 Received: from l-fxstation-3a.rd.francetelecom.fr ([2.10.73.72]) by mwinf5d61 with ME id R2cT1n00j1ZaZxN032cYAc; Tue, 11 Feb 2014 15:36:33 +0100 From: Francois-Xavier Le Bail To: NETDEV , David Miller Subject: [PATCH] net: rtnetlink: fix correct size given to memset Date: Tue, 11 Feb 2014 15:06:38 +0100 Message-Id: <1392127598-3719-1-git-send-email-fx.lebail@yahoo.com> X-Mailer: git-send-email 1.7.10.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Find by cppcheck: [net/core/rtnetlink.c:1842]: (warning) Using size of pointer linkinfo instead of size of its data. Signed-off-by: Francois-Xavier Le Bail --- The diagnosis of cppcheck seems relevant. net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 048dc8d..9a5dbf1 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1839,7 +1839,7 @@ replay: if (err < 0) return err; } else - memset(linkinfo, 0, sizeof(linkinfo)); + memset(linkinfo, 0, sizeof(*linkinfo)); if (linkinfo[IFLA_INFO_KIND]) { nla_strlcpy(kind, linkinfo[IFLA_INFO_KIND], sizeof(kind));