From patchwork Mon Feb 3 23:33:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 316383 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 94BED2C0096 for ; Tue, 4 Feb 2014 10:33:52 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754370AbaBCXdp (ORCPT ); Mon, 3 Feb 2014 18:33:45 -0500 Received: from mail-lb0-f179.google.com ([209.85.217.179]:34453 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754350AbaBCXdn (ORCPT ); Mon, 3 Feb 2014 18:33:43 -0500 Received: by mail-lb0-f179.google.com with SMTP id l4so5762639lbv.24 for ; Mon, 03 Feb 2014 15:33:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j31BbeB1ouyx2JLNmIHWIxHPRPr4tn8CIZ3mjEkBgM0=; b=hU1/DrS0hDD2A8aHzX8KU8hfBnZu4bcyS0ZOogW+mL/GB2/uGizEcYRfdbjMQJk4Zy I/a+81NXdobwtGLU6gk6tIuX1OG1iryfQoQBVCpIMH6w4Pxc/hz03pwWYZDZzyCExXxO MuVChXqstR7YRWrIRsW1ZoxTG5HCHexpKEpF8hxx5l8M1pRXp9+Wo3maD24MG4BbHpyR v/JJdw0nNX64NXqvijdiDl/1nDATs3ZM5mt2g3nr2zK0WRjy3g+QdU7jELE+GnUcM3jS dIXKl9H2sFEaKn7gPqLy/z/fPProNQOb+fTvoEnzeyuWOEN8PqHnSApq+hHIvOQWN9pp EFAA== X-Received: by 10.152.170.232 with SMTP id ap8mr3502348lac.40.1391470422349; Mon, 03 Feb 2014 15:33:42 -0800 (PST) Received: from octofox.metropolis ([188.134.19.124]) by mx.google.com with ESMTPSA id mo3sm23040674lbb.17.2014.02.03.15.33.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Feb 2014 15:33:41 -0800 (PST) From: Max Filippov To: linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org Cc: Chris Zankel , Marc Gauthier , "David S. Miller" , Ben Hutchings , Florian Fainelli , Max Filippov Subject: [PATCH v3 1/2] net: ethoc: don't advertise gigabit speed on attached PHY Date: Tue, 4 Feb 2014 03:33:09 +0400 Message-Id: <1391470390-31569-2-git-send-email-jcmvbkbc@gmail.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1391470390-31569-1-git-send-email-jcmvbkbc@gmail.com> References: <1391470390-31569-1-git-send-email-jcmvbkbc@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org OpenCores 10/100 Mbps MAC does not support speeds above 100 Mbps, but does not disable advertisement when PHY supports them. This results in non-functioning network when the MAC is connected to a gigabit PHY connected to a gigabit switch. The fix is to disable gigabit speed advertisement on attached PHY unconditionally. Signed-off-by: Max Filippov --- Changes v2->v3: - don't call phy_start_aneg to force phylib to disable gigabit advertisement. Changes v1->v2: - disable both gigabit advertisement and support. drivers/net/ethernet/ethoc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c index 5ca7719..6aef639 100644 --- a/drivers/net/ethernet/ethoc.c +++ b/drivers/net/ethernet/ethoc.c @@ -691,6 +691,11 @@ static int ethoc_mdio_probe(struct net_device *dev) } priv->phy = phy; + phy->advertising &= ~(ADVERTISED_1000baseT_Full | + ADVERTISED_1000baseT_Half); + phy->supported &= ~(SUPPORTED_1000baseT_Full | + SUPPORTED_1000baseT_Half); + return 0; }