From patchwork Wed Jan 29 06:00:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 314919 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8307E2C0079 for ; Wed, 29 Jan 2014 17:01:37 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755764AbaA2GAy (ORCPT ); Wed, 29 Jan 2014 01:00:54 -0500 Received: from mail-lb0-f170.google.com ([209.85.217.170]:37987 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755432AbaA2GAv (ORCPT ); Wed, 29 Jan 2014 01:00:51 -0500 Received: by mail-lb0-f170.google.com with SMTP id u14so1115019lbd.15 for ; Tue, 28 Jan 2014 22:00:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5D452UVW9/+WlSe3KCeAzBdHkrA+6M/tFlJBrH72z10=; b=XDKZNGpp+w3dwn2qCaD3vYJJL+dEF4fRRXSYOqWmKY0AZlasTPHVnOCI4eMzruRfh3 b6ZJxJwYe0uyP4WUAgR9SakRxShytW1Jo2KMtr2SgPxblq3EV8j+X2nV/2pbYlkVoblX 5Noamis7yr8OqCRR7+o8jKKajeBD5bicqFQ6B+c+e7tsGoXUTluKlgNgJbHsNqSa5oTN UcBDLDwjNNyP91BrogzViR1Pjp0VENtkbEpw/1rngVZxZfEBBsxynNYBlrwrsZ4QXeg8 NliDUtrxcr6gIvm/WC7jtrYcaHBYLXMm1B6pP4z6OwI7Rjx5DuUMztFDNCyCoEkpV2mC 4sEw== X-Received: by 10.112.92.112 with SMTP id cl16mr3777242lbb.15.1390975247411; Tue, 28 Jan 2014 22:00:47 -0800 (PST) Received: from octofox.metropolis ([188.134.19.124]) by mx.google.com with ESMTPSA id h7sm1263226lbj.1.2014.01.28.22.00.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jan 2014 22:00:46 -0800 (PST) From: Max Filippov To: linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Chris Zankel , Marc Gauthier , "David S. Miller" , Ben Hutchings , Florian Fainelli , Max Filippov Subject: [PATCH v2 2/4] net: ethoc: don't advertise gigabit speed on attached PHY Date: Wed, 29 Jan 2014 10:00:16 +0400 Message-Id: <1390975218-13863-3-git-send-email-jcmvbkbc@gmail.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1390975218-13863-1-git-send-email-jcmvbkbc@gmail.com> References: <1390975218-13863-1-git-send-email-jcmvbkbc@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org OpenCores 10/100 Mbps MAC does not support speeds above 100 Mbps, but does not disable advertisement when PHY supports them. This results in non-functioning network when the MAC is connected to a gigabit PHY connected to a gigabit switch. The fix is to disable gigabit speed advertisement on attached PHY unconditionally. Signed-off-by: Max Filippov --- Changes v1->v2: - disable both gigabit advertisement and support. drivers/net/ethernet/ethoc.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c index 4de8cfd..5643b2d 100644 --- a/drivers/net/ethernet/ethoc.c +++ b/drivers/net/ethernet/ethoc.c @@ -688,6 +688,14 @@ static int ethoc_mdio_probe(struct net_device *dev) } priv->phy = phy; + phy_update_advert(phy, + ADVERTISED_1000baseT_Full | + ADVERTISED_1000baseT_Half, 0); + phy_start_aneg(phy); + phy_update_supported(phy, + SUPPORTED_1000baseT_Full | + SUPPORTED_1000baseT_Half, 0); + return 0; }