From patchwork Wed Jan 29 06:00:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 314921 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 093A92C00AC for ; Wed, 29 Jan 2014 17:02:17 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756105AbaA2GCC (ORCPT ); Wed, 29 Jan 2014 01:02:02 -0500 Received: from mail-lb0-f180.google.com ([209.85.217.180]:60506 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbaA2GAr (ORCPT ); Wed, 29 Jan 2014 01:00:47 -0500 Received: by mail-lb0-f180.google.com with SMTP id n15so1131960lbi.11 for ; Tue, 28 Jan 2014 22:00:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MJrbHnR9mt5sWyBBAX0AJFfJPPKJRTWjjYR1n0DcwJo=; b=hxAdCctmFY2kufgqPDDzrT8QEdsMmG4gjbKYz9lnDayp9lgB5C3wWEWFm5qqZEfBiy Sq9+o9D1rqqnkcLNfR7T4w6ja2EYZMbWZ4mb7MaEzbNX7d7EF5O7gLkP+sURlw0bUCmp Cbn6Zq8rjKtNQt1MePW7GFgkoC2kF6AFdWUlxOb7Rn9sdUqYVs/S1TCAjt4udrUG99YJ dZH6YA2FNuyU6ZddaVLzJB7tfcXrMQ4WAlL9iPb6FJjzJYPKAj+QePSUcTn9jBfYAZo4 OF28w5bY54XnIbZTzLsYq3NsMFj/wAaJG9tB7NbwCEceB9COpUMBgIx6TPcGfmwB37l8 r7vQ== X-Received: by 10.112.188.135 with SMTP id ga7mr3843022lbc.5.1390975245717; Tue, 28 Jan 2014 22:00:45 -0800 (PST) Received: from octofox.metropolis ([188.134.19.124]) by mx.google.com with ESMTPSA id h7sm1263226lbj.1.2014.01.28.22.00.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jan 2014 22:00:44 -0800 (PST) From: Max Filippov To: linux-xtensa@linux-xtensa.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Chris Zankel , Marc Gauthier , "David S. Miller" , Ben Hutchings , Florian Fainelli , Max Filippov Subject: [PATCH v2 1/4] phy: provide accessors for 'advertising' and 'supported' fields Date: Wed, 29 Jan 2014 10:00:15 +0400 Message-Id: <1390975218-13863-2-git-send-email-jcmvbkbc@gmail.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1390975218-13863-1-git-send-email-jcmvbkbc@gmail.com> References: <1390975218-13863-1-git-send-email-jcmvbkbc@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Many network drivers directly modify phy_device::advertising and phy_device::supported. Provide accessors to these fields to better isolate phylib from its users. Suggested-by: Ben Hutchings Signed-off-by: Max Filippov --- Changes v1->v2: - new patch include/linux/phy.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 48a4dc3..2ae58f8 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -559,6 +559,18 @@ static inline int phy_read_status(struct phy_device *phydev) { return phydev->drv->read_status(phydev); } +static inline void phy_update_advert(struct phy_device *phydev, u32 clear, + u32 set) +{ + phydev->advertising = (phydev->advertising & ~clear) | set; +} + +static inline void phy_update_supported(struct phy_device *phydev, u32 clear, + u32 set) +{ + phydev->supported = (phydev->supported & ~clear) | set; +} + int genphy_setup_forced(struct phy_device *phydev); int genphy_restart_aneg(struct phy_device *phydev); int genphy_config_aneg(struct phy_device *phydev);