diff mbox

[net-next,1/2] act_police: remove unnecessary null pointer check

Message ID 1387265357-19352-2-git-send-email-yangyingliang@huawei.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Yang Yingliang Dec. 17, 2013, 7:29 a.m. UTC 
It already has a NULL pointer check of rtab in qdisc_put_rtab().
Remove the check outside of qdisc_put_rtab().

Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 net/sched/act_police.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff mbox

Patch

diff --git a/net/sched/act_police.c b/net/sched/act_police.c
index 16a62c3..cf01c97 100644
--- a/net/sched/act_police.c
+++ b/net/sched/act_police.c
@@ -277,10 +277,8 @@  override:
 failure_unlock:
 	spin_unlock_bh(&police->tcf_lock);
 failure:
-	if (P_tab)
-		qdisc_put_rtab(P_tab);
-	if (R_tab)
-		qdisc_put_rtab(R_tab);
+	qdisc_put_rtab(P_tab);
+	qdisc_put_rtab(R_tab);
 	if (ret == ACT_P_CREATED)
 		kfree(police);
 	return err;