From patchwork Fri Dec 13 09:20:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Hesselbarth X-Patchwork-Id: 300954 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 951932C00A0 for ; Fri, 13 Dec 2013 20:23:45 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752247Ab3LMJWD (ORCPT ); Fri, 13 Dec 2013 04:22:03 -0500 Received: from mail-ea0-f179.google.com ([209.85.215.179]:45469 "EHLO mail-ea0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059Ab3LMJUl (ORCPT ); Fri, 13 Dec 2013 04:20:41 -0500 Received: by mail-ea0-f179.google.com with SMTP id r15so737484ead.10 for ; Fri, 13 Dec 2013 01:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0MBq3MxgpmuHN0RRp4hiAs9Da3Gl2rzxuCcgfoVMLUg=; b=BBmDQV3mYnmZ1V1wFo9LS0v50HZG73CwBEaIJX4/YUKzKY1kkIviMrKZsesMoyX/Ua 2e00SgTwPX625fujMqF0nDjLL7IAtzigIZ5259iuEFevHyZsjfCJg5t4WINuXeko3uDG rjzuP/VISDx+sSeym2MR30aButezuQj6mDvFXiRGQrqNrvUrexU0BQCXYdm0JwwbIHU4 2WIyFl82ZNRIJsqUS1lfs3bVl8C7qDDt2SWtKttCLOTPY4gYoDc2AwSkF1R+keTJsmn/ pE+4HsKNWrsLirtam8ybLcrX9bB0m0VBVOOkZfJCnkf0xLpmlUcT2jZwZ5byGiehbQL5 ZrCg== X-Received: by 10.14.178.197 with SMTP id f45mr1599084eem.47.1386926440679; Fri, 13 Dec 2013 01:20:40 -0800 (PST) Received: from topkick.lan (dslc-082-083-251-183.pools.arcor-ip.net. [82.83.251.183]) by mx.google.com with ESMTPSA id v1sm4547868eef.9.2013.12.13.01.20.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Dec 2013 01:20:39 -0800 (PST) From: Sebastian Hesselbarth To: Sebastian Hesselbarth Cc: Sebastian Hesselbarth , David Miller , Florian Fainelli , Mugunthan V N , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/5] net: phy: resume/suspend PHYs on attach/detach Date: Fri, 13 Dec 2013 10:20:28 +0100 Message-Id: <1386926429-28818-5-git-send-email-sebastian.hesselbarth@gmail.com> In-Reply-To: <1386513631-11284-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1386513631-11284-1-git-send-email-sebastian.hesselbarth@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This ensures PHYs are resumed on attach and suspended on detach. Signed-off-by: Sebastian Hesselbarth Acked-by: Mugunthan V N Reviewed-by: Florian Fainelli --- Cc: David Miller Cc: Florian Fainelli Cc: Mugunthan V N Cc: netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/net/phy/phy_device.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 6f0e9e4..3903f44 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -570,6 +570,8 @@ static int phy_attach_direct(struct net_device *dev, struct phy_device *phydev, if (err) phy_detach(phydev); + phy_resume(phydev); + return err; } @@ -615,6 +617,7 @@ void phy_detach(struct phy_device *phydev) { phydev->attached_dev->phydev = NULL; phydev->attached_dev = NULL; + phy_suspend(phydev); /* If the device had no specific driver before (i.e. - it * was using the generic driver), we unbind the device