From patchwork Wed Dec 4 15:44:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Hesselbarth X-Patchwork-Id: 296572 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 790D42C00A8 for ; Thu, 5 Dec 2013 02:46:49 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933026Ab3LDPqe (ORCPT ); Wed, 4 Dec 2013 10:46:34 -0500 Received: from mail-ea0-f171.google.com ([209.85.215.171]:41685 "EHLO mail-ea0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932640Ab3LDPo7 (ORCPT ); Wed, 4 Dec 2013 10:44:59 -0500 Received: by mail-ea0-f171.google.com with SMTP id h10so10801168eak.16 for ; Wed, 04 Dec 2013 07:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/TSajuoPWaFdmmq/Xh5GQN4EnQDQjBtBpDZHhpQmFsw=; b=H2v9xnTNg97KXJC7frXA6fbMkmCyrIsbRJGs7VTtlUPEcVfxGaiQyEZNEGcp+ATOFL 9naP6pJzWDAqE+5vylL05XvIvwPiHrccljFygEd4rbehf62b+GT5nUWw22RGsu3x6PDd 3mHuWiooFa+cPa6ix8P+ql5PUASmk5n9XPvzbK/zU6hbO3lsQ9fHT9rVvJ5aL4hUBKnb //Iolw/gLkPpWDRRW1Tp7IesitmPOr7vbVWgNvix3A8jjQ02+pfN5QwTlD9AYleb3m0T mfD63nrfDBmVXRJCCBtepNkulclNE+dPPr7n9SMFWYTMPBgoku+GIJLbiqj6oF9JoYU2 msnQ== X-Received: by 10.14.5.12 with SMTP id 12mr76731962eek.9.1386171898335; Wed, 04 Dec 2013 07:44:58 -0800 (PST) Received: from topkick.lan (dslc-082-083-251-183.pools.arcor-ip.net. [82.83.251.183]) by mx.google.com with ESMTPSA id 44sm95543140eek.5.2013.12.04.07.44.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Dec 2013 07:44:57 -0800 (PST) From: Sebastian Hesselbarth To: Sebastian Hesselbarth Cc: Sebastian Hesselbarth , David Miller , Florian Fainelli , Mugunthan V N , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH RFCv2 4/6] net: phy: resume/suspend PHYs on attach/detach Date: Wed, 4 Dec 2013 16:44:46 +0100 Message-Id: <1386171888-28190-5-git-send-email-sebastian.hesselbarth@gmail.com> In-Reply-To: <1384978913-8052-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1384978913-8052-1-git-send-email-sebastian.hesselbarth@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This ensures PHYs are resumed on attach and suspended on detach. Signed-off-by: Sebastian Hesselbarth --- Changelog: RFCv1->RFCv2: - none Cc: David Miller Cc: Florian Fainelli Cc: Mugunthan V N Cc: netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/net/phy/phy_device.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 6f0e9e4..3903f44 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -570,6 +570,8 @@ static int phy_attach_direct(struct net_device *dev, struct phy_device *phydev, if (err) phy_detach(phydev); + phy_resume(phydev); + return err; } @@ -615,6 +617,7 @@ void phy_detach(struct phy_device *phydev) { phydev->attached_dev->phydev = NULL; phydev->attached_dev = NULL; + phy_suspend(phydev); /* If the device had no specific driver before (i.e. - it * was using the generic driver), we unbind the device