Message ID | 1385077794-17022-1-git-send-email-vincent.stehle@laposte.net |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
At Fri, 22 Nov 2013 00:49:54 +0100, Vincent Stehlé wrote: > > Teles PCI and HFC PCI-bus refuse to build on big-endian ARM; disable them in > Kconfig. > > Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> > Cc: Karsten Keil <isdn@linux-pingi.de> > --- > > Hi, > > This can be seen on e.g. linux next-20131121 with arm allyesconfig. > > Best regards, > > V. > > drivers/isdn/hisax/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig > index d9edcc9..53dbb75 100644 > --- a/drivers/isdn/hisax/Kconfig > +++ b/drivers/isdn/hisax/Kconfig > @@ -109,7 +109,7 @@ config HISAX_16_3 > > config HISAX_TELESPCI > bool "Teles PCI" > - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) > + depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN))) Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally? depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM)) Or maybe just depends on PCI && (X86 || BROKEN) (Alpha? Can anyone test? :) Takashi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 22.11.2013 08:29, schrieb Takashi Iwai: > At Fri, 22 Nov 2013 00:49:54 +0100, > Vincent Stehlé wrote: >> >> Teles PCI and HFC PCI-bus refuse to build on big-endian ARM; disable them in >> Kconfig. >> >> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> >> Cc: Karsten Keil <isdn@linux-pingi.de> >> --- >> >> Hi, >> >> This can be seen on e.g. linux next-20131121 with arm allyesconfig. >> >> Best regards, >> >> V. >> >> drivers/isdn/hisax/Kconfig | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig >> index d9edcc9..53dbb75 100644 >> --- a/drivers/isdn/hisax/Kconfig >> +++ b/drivers/isdn/hisax/Kconfig >> @@ -109,7 +109,7 @@ config HISAX_16_3 >> >> config HISAX_TELESPCI >> bool "Teles PCI" >> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) >> + depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN))) > > Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally? > > depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM)) > > Or maybe just > > depends on PCI && (X86 || BROKEN) > > (Alpha? Can anyone test? :) I never got this card so it was never in my tests, if I remember correctely somebody had it running with Alpha before 2000. And yes I'm fine if we simplify this mess to only X86. Karsten -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Nov 22, 2013 at 8:29 AM, Takashi Iwai <tiwai@suse.de> wrote: >> config HISAX_TELESPCI >> bool "Teles PCI" >> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) >> + depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN))) > > Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally? > > depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM)) CPU_LITTLE_ENDIAN is not defined on all little endian platforms, only on those that can support both big and little endian. But I guess it wouldn't hurt to move CPU_{BIG,LITTLE}_ENDIAN to a common Kconfig file. > Or maybe just > > depends on PCI && (X86 || BROKEN) > > (Alpha? Can anyone test? :) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
At Fri, 22 Nov 2013 10:19:07 +0100, Geert Uytterhoeven wrote: > > On Fri, Nov 22, 2013 at 8:29 AM, Takashi Iwai <tiwai@suse.de> wrote: > >> config HISAX_TELESPCI > >> bool "Teles PCI" > >> - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) > >> + depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN))) > > > > Isn't it a bit better to exclude CPU_LITTLE_ENDIAN globally? > > > > depends on PCI && CPU_LITTLE_ENDIAN && (BROKEN || !(SPARC || PPC || PARISC || M68K || MIPS || FRV || XTENSA || ARM)) > > CPU_LITTLE_ENDIAN is not defined on all little endian platforms, > only on those that can support both big and little endian. Ah, a good point. > But I guess it wouldn't hurt to move CPU_{BIG,LITTLE}_ENDIAN to > a common Kconfig file. Yeah, this make life easier. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/isdn/hisax/Kconfig b/drivers/isdn/hisax/Kconfig index d9edcc9..53dbb75 100644 --- a/drivers/isdn/hisax/Kconfig +++ b/drivers/isdn/hisax/Kconfig @@ -109,7 +109,7 @@ config HISAX_16_3 config HISAX_TELESPCI bool "Teles PCI" - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) + depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN))) help This enables HiSax support for the Teles PCI. See <file:Documentation/isdn/README.HiSax> on how to configure it. @@ -318,7 +318,7 @@ config HISAX_GAZEL config HISAX_HFC_PCI bool "HFC PCI-Bus cards" - depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN))) + depends on PCI && (BROKEN || !(SPARC || PPC || PARISC || M68K || (MIPS && !CPU_LITTLE_ENDIAN) || FRV || (XTENSA && !CPU_LITTLE_ENDIAN) || (ARM && !CPU_LITTLE_ENDIAN))) help This enables HiSax support for the HFC-S PCI 2BDS0 based cards.
Teles PCI and HFC PCI-bus refuse to build on big-endian ARM; disable them in Kconfig. Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net> Cc: Karsten Keil <isdn@linux-pingi.de> --- Hi, This can be seen on e.g. linux next-20131121 with arm allyesconfig. Best regards, V. drivers/isdn/hisax/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)