From patchwork Wed Nov 20 20:21:52 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Hesselbarth X-Patchwork-Id: 292858 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E1B2F2C008E for ; Thu, 21 Nov 2013 07:23:53 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755196Ab3KTUWI (ORCPT ); Wed, 20 Nov 2013 15:22:08 -0500 Received: from mail-ea0-f182.google.com ([209.85.215.182]:59760 "EHLO mail-ea0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755185Ab3KTUWE (ORCPT ); Wed, 20 Nov 2013 15:22:04 -0500 Received: by mail-ea0-f182.google.com with SMTP id o10so5220133eaj.27 for ; Wed, 20 Nov 2013 12:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=oYo8srPQrf3nUrLOg4VYvm3fgeXe+ZDMfK5RHS4IIV0=; b=XLvLacq5ZSR6SLC8jZ5zgdCEaqBaGrNfcg2BPlxTYso5RLuZ1gEag2VxeKjRxtgXb5 ZIOVE7nfFfBYIN56b9x6Ct4EX8UNlNIP7T09E2bsZYzfw2NrKgWBJ8DPsklvUazbHi8M VZ67YHt0TBAuiTW3BegNCqfWUaOm9pYVBoiKMnox4/x6OLpIWBAHQCMjx4eHg/W2Dyik DdQ6Ki68Wr9Ii7XLQbvdUTQo/47Nk508k/Qx8Jjvy59eqTSrK1/pUWikNtLDGC7tEKM4 wzgyXHrhCtorrgQdIkGfZHsgpHTBm3OS134Gmc4AFmw1o+ESSfPZFVHf9FPdh54axY0Y Dphg== X-Received: by 10.15.26.131 with SMTP id n3mr3331121eeu.21.1384978923084; Wed, 20 Nov 2013 12:22:03 -0800 (PST) Received: from topkick.lan (dslc-082-083-251-183.pools.arcor-ip.net. [82.83.251.183]) by mx.google.com with ESMTPSA id b42sm63364466eem.9.2013.11.20.12.22.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2013 12:22:02 -0800 (PST) From: Sebastian Hesselbarth To: Sebastian Hesselbarth Cc: Sebastian Hesselbarth , "David S. Miller" , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH RFC v1 6/7] net: mvneta: resume/suspend PHY on port start/stop Date: Wed, 20 Nov 2013 21:21:52 +0100 Message-Id: <1384978913-8052-7-git-send-email-sebastian.hesselbarth@gmail.com> In-Reply-To: <1384978913-8052-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1384978913-8052-1-git-send-email-sebastian.hesselbarth@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Network PHYs consume a noticable amount of power. This adds phy_resume on start_dev and phy_suspend on stop_dev to save this power if the port is down anyway. Signed-off-by: Sebastian Hesselbarth --- Cc: David S. Miller Cc: netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/net/ethernet/marvell/mvneta.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index b8e232b..8688e91 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -2194,6 +2194,7 @@ static void mvneta_start_dev(struct mvneta_port *pp) mvreg_write(pp, MVNETA_INTR_NEW_MASK, MVNETA_RX_INTR_MASK(rxq_number)); + phy_resume(pp->phy_dev); phy_start(pp->phy_dev); netif_tx_start_all_queues(pp->dev); } @@ -2201,6 +2202,7 @@ static void mvneta_start_dev(struct mvneta_port *pp) static void mvneta_stop_dev(struct mvneta_port *pp) { phy_stop(pp->phy_dev); + phy_suspend(pp->phy_dev); napi_disable(&pp->napi);