From patchwork Tue Nov 12 15:34:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Fietkau X-Patchwork-Id: 290687 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0C00F2C0099 for ; Wed, 13 Nov 2013 02:35:13 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755991Ab3KLPfI (ORCPT ); Tue, 12 Nov 2013 10:35:08 -0500 Received: from nbd.name ([46.4.11.11]:59735 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755883Ab3KLPfE (ORCPT ); Tue, 12 Nov 2013 10:35:04 -0500 Received: by nf.local (Postfix, from userid 501) id DE9A55F225E0; Tue, 12 Nov 2013 16:34:41 +0100 (CET) From: Felix Fietkau To: netdev@vger.kernel.org Cc: linux-usb@vger.kernel.org, dcbw@redhat.com Subject: [PATCH] usbnet: fix status interrupt urb handling Date: Tue, 12 Nov 2013 16:34:41 +0100 Message-Id: <1384270481-30972-1-git-send-email-nbd@openwrt.org> X-Mailer: git-send-email 1.8.3.4 (Apple Git-47) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since commit 7b0c5f21f348a66de495868b8df0284e8dfd6bbf "sierra_net: keep status interrupt URB active", sierra_net triggers status interrupt polling before the net_device is opened (in order to properly receive the sync message response). To be able to receive further interrupts, the interrupt urb needs to be re-submitted, so this patch removes the bogus check for netif_running(). Cc: stable@vger.kernel.org Signed-off-by: Felix Fietkau Tested-by: Dan Williams --- drivers/net/usb/usbnet.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 90a429b..8494bb5 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -204,9 +204,6 @@ static void intr_complete (struct urb *urb) break; } - if (!netif_running (dev->net)) - return; - status = usb_submit_urb (urb, GFP_ATOMIC); if (status != 0) netif_err(dev, timer, dev->net,