From patchwork Mon Oct 14 20:33:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tedheadster X-Patchwork-Id: 283383 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F22A02C009C for ; Tue, 15 Oct 2013 07:33:42 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933195Ab3JNUd0 (ORCPT ); Mon, 14 Oct 2013 16:33:26 -0400 Received: from mail-qe0-f44.google.com ([209.85.128.44]:54035 "EHLO mail-qe0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933190Ab3JNUdY (ORCPT ); Mon, 14 Oct 2013 16:33:24 -0400 Received: by mail-qe0-f44.google.com with SMTP id 6so5620705qeb.17 for ; Mon, 14 Oct 2013 13:33:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=MqYTCa5d1Q/YQMUnHGDcp2xNu69+0O047Zfc9TpP1J8=; b=CsOW2t8Rx0Ke/M/GXcL2gfK4rmR65YiWlVM9VOTsSwZn1MUS9cs0UkltJduTIGbvLi xG3JBBjKSsKD3dfalRP2yKePzqoYQwudih63F+YARCWc+EWr2UGHD3D94G8clQdyCWNl LYFr1juhJbj+duz13dLoR8Prcav7IPy72cgWuxtqHG+ye2SBrfybHjtS4ZsC/dS2rw5A +dhAuH7eQzBYAdKGjM7lADROijRN0nn+B4v3hK3CVYZVD0mqU38iYoaRdx3NGbzBsArP 8NPiSFCTDj1t7gK8FM4l3/6EB2DD1Ce9NQsoNZhbbPM+yub1D0eSHFYDhGIkS6vNZKMW 3Mhw== X-Received: by 10.49.17.137 with SMTP id o9mr29635420qed.72.1381782803444; Mon, 14 Oct 2013 13:33:23 -0700 (PDT) Received: from localhost.localdomain (pool-72-81-142-116.bltmmd.fios.verizon.net. [72.81.142.116]) by mx.google.com with ESMTPSA id b10sm35636993qeg.7.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 14 Oct 2013 13:33:21 -0700 (PDT) From: Matthew Whitehead To: netdev@vger.kernel.org Cc: Matthew Whitehead Subject: [PATCH net-next] 8390 ei_debug : Reenable the use of debugging in 8390 based chips Date: Mon, 14 Oct 2013 16:33:14 -0400 Message-Id: <1381782794-11334-1-git-send-email-tedheadster@gmail.com> X-Mailer: git-send-email 1.7.2.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Ethernet boards based on the 8390 chip had an '#ifdef notdef' disabling the use of the debug variable ei_debug. Reenable it for those of us who still occasionally use it. Signed-off-by: Matthew Whitehead --- drivers/net/ethernet/8390/8390.h | 2 +- drivers/net/ethernet/8390/axnet_cs.c | 5 ----- drivers/net/ethernet/8390/lib8390.c | 4 ++-- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/8390/8390.h b/drivers/net/ethernet/8390/8390.h index ef325ff..2375087 100644 --- a/drivers/net/ethernet/8390/8390.h +++ b/drivers/net/ethernet/8390/8390.h @@ -21,7 +21,7 @@ struct e8390_pkt_hdr { unsigned short count; /* header + packet length in bytes */ }; -#ifdef notdef +#ifdef EI_DEBUG extern int ei_debug; #else #define ei_debug 1 diff --git a/drivers/net/ethernet/8390/axnet_cs.c b/drivers/net/ethernet/8390/axnet_cs.c index d801c141..581560c 100644 --- a/drivers/net/ethernet/8390/axnet_cs.c +++ b/drivers/net/ethernet/8390/axnet_cs.c @@ -810,11 +810,6 @@ module_pcmcia_driver(axnet_cs_driver); #define ei_block_input (ei_local->block_input) #define ei_get_8390_hdr (ei_local->get_8390_hdr) -/* use 0 for production, 1 for verification, >2 for debug */ -#ifndef ei_debug -int ei_debug = 1; -#endif - /* Index to functions. */ static void ei_tx_intr(struct net_device *dev); static void ei_tx_err(struct net_device *dev); diff --git a/drivers/net/ethernet/8390/lib8390.c b/drivers/net/ethernet/8390/lib8390.c index b329f5c..4ec5e38 100644 --- a/drivers/net/ethernet/8390/lib8390.c +++ b/drivers/net/ethernet/8390/lib8390.c @@ -100,8 +100,8 @@ #define ei_get_8390_hdr (ei_local->get_8390_hdr) /* use 0 for production, 1 for verification, >2 for debug */ -#ifndef ei_debug -int ei_debug = 1; +#ifdef EI_DEBUG +int ei_debug = EI_DEBUG; #endif /* Index to functions. */