From patchwork Tue Oct 8 00:30:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: duanjiong X-Patchwork-Id: 281177 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0E6712C0090 for ; Tue, 8 Oct 2013 03:31:21 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756489Ab3JGQbM (ORCPT ); Mon, 7 Oct 2013 12:31:12 -0400 Received: from mail-pb0-f51.google.com ([209.85.160.51]:53135 "EHLO mail-pb0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756480Ab3JGQbI (ORCPT ); Mon, 7 Oct 2013 12:31:08 -0400 Received: by mail-pb0-f51.google.com with SMTP id jt11so7498120pbb.10 for ; Mon, 07 Oct 2013 09:31:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=0GhhT8kWGlhdyELQytSoXXXpSIwtWXs/oAMcv2GrGmw=; b=cIQApnq8LsRYJb0RmkKV0DMgTkvy2Nd1qhUP/40fk/dTETn7IRVrD8YhrvsG9JuIDZ dYmA6H2Wd561lKj/6+5Ou4pobGoKooh27OQ/DhrgKUUQMGc/f+/HOrD+ldGzwhtFk8lE HiWTlm5688QXwcISqcgQKAvni4AgnxGGa+P7QYxv5rESpVxbqKFt0hjdnOy/c87ZcL0G TPfrK14wV4hiGQoUjVyw8BA8lHLn4iGH/VFPY+LqdUxPRk3MJLlcEMkzzckhaXopUBHF 5u1IGZh9CQRl7meJoSKcA/k8cKw41InZ8Z7GD60MaMLlqyINL/B/3ciBrLnbeYOl4EHl lLHg== X-Received: by 10.66.25.133 with SMTP id c5mr33153388pag.4.1381163467163; Mon, 07 Oct 2013 09:31:07 -0700 (PDT) Received: from localhost.localdomain.localdomain ([117.89.42.103]) by mx.google.com with ESMTPSA id l8sm34323628pbl.22.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 07 Oct 2013 09:31:06 -0700 (PDT) From: djduanjiong@gmail.com To: Inaky Perez-Gonzalez , "David S. Miller" , linux-wimax@intel.com Cc: wimax@linuxwimax.org, netdev@vger.kernel.org, Duan Jiong Subject: [PATCH] wimax: Use WARN(1, ...) rather than printk followed by WARN_ON(1) Date: Mon, 7 Oct 2013 17:30:38 -0700 Message-Id: <1381192238-6486-1-git-send-email-duanj.fnst@cn.fujitsu.com> X-Mailer: git-send-email 1.7.7.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Duan Jiong Signed-off-by: Duan Jiong --- net/wimax/id-table.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/net/wimax/id-table.c b/net/wimax/id-table.c index 72273ab..635a4d2 100644 --- a/net/wimax/id-table.c +++ b/net/wimax/id-table.c @@ -136,10 +136,8 @@ void wimax_id_table_release(void) return; #endif spin_lock(&wimax_id_table_lock); - list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node) { - printk(KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n", + list_for_each_entry(wimax_dev, &wimax_id_table, id_table_node) + WARN(1, KERN_ERR "BUG: %s wimax_dev %p ifindex %d not cleared\n", __func__, wimax_dev, wimax_dev->net_dev->ifindex); - WARN_ON(1); - } spin_unlock(&wimax_id_table_lock); }