From patchwork Mon Sep 30 21:28:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Korsgaard X-Patchwork-Id: 279274 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 63DE12C009F for ; Tue, 1 Oct 2013 07:28:39 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756224Ab3I3V2g (ORCPT ); Mon, 30 Sep 2013 17:28:36 -0400 Received: from mail-ea0-f177.google.com ([209.85.215.177]:58408 "EHLO mail-ea0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754855Ab3I3V2f (ORCPT ); Mon, 30 Sep 2013 17:28:35 -0400 Received: by mail-ea0-f177.google.com with SMTP id f15so2950363eak.22 for ; Mon, 30 Sep 2013 14:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=hMMtNHoy4ftdU9Ovx1LbuVVhZdk6nY9I4ds0YFiGbqk=; b=EvubiVF1piI8xKxmKD1oISIcCGRuLkFcM21LNGXrKil1SBmW/SgBq/sfzibkA7Iu5g iwsTAftZBLNxte/3V3+t7l6zrr3q+zXw1Zq1NCckoNgt5G4K64wXty+/8Z95geEwq40E pMxMfIuwQBhyxr68Bghk0J2iTMV1seBM4+jcbUzD6sVyBFKbSIqKycVNydo2NP2EWI+J Jw+U0kiaf9sKu5PjTx02WGFNqlI9JZsUigivNu1ab4NEPPOngquVpSYfTMKCdcictHRK vyN7kOhG5O5t+tp5SeoCuvMlDeVzS13cmXSWpZYNFWaMnbOTnqmTlklesClgGkjudYLy bf3w== X-Received: by 10.14.210.8 with SMTP id t8mr40039196eeo.39.1380576513946; Mon, 30 Sep 2013 14:28:33 -0700 (PDT) Received: from dell.be.48ers.dk ([2001:6f8:1434:0:6267:20ff:fe4e:21b6]) by mx.google.com with ESMTPSA id a43sm5411028eep.9.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 30 Sep 2013 14:28:33 -0700 (PDT) Received: from peko by dell.be.48ers.dk with local (Exim 4.80) (envelope-from ) id 1VQl15-0002EU-Di; Mon, 30 Sep 2013 23:28:31 +0200 From: Peter Korsgaard To: netdev@vger.kernel.org, davem@davemloft.net Cc: joseph_chang@davicom.com.tw, Peter Korsgaard Subject: [PATCH] dm9601: fix IFF_ALLMULTI handling Date: Mon, 30 Sep 2013 23:28:20 +0200 Message-Id: <1380576500-8531-1-git-send-email-peter@korsgaard.com> X-Mailer: git-send-email 1.7.10.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Pass-all-multicast is controlled by bit 3 in RX control, not bit 2 (pass undersized frames). Reported-by: Joseph Chang Signed-off-by: Peter Korsgaard --- drivers/net/usb/dm9601.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/dm9601.c b/drivers/net/usb/dm9601.c index 2dbb946..c6867f9 100644 --- a/drivers/net/usb/dm9601.c +++ b/drivers/net/usb/dm9601.c @@ -303,7 +303,7 @@ static void dm9601_set_multicast(struct net_device *net) rx_ctl |= 0x02; } else if (net->flags & IFF_ALLMULTI || netdev_mc_count(net) > DM_MAX_MCAST) { - rx_ctl |= 0x04; + rx_ctl |= 0x08; } else if (!netdev_mc_empty(net)) { struct netdev_hw_addr *ha;