From patchwork Sun Jul 21 16:25:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 260532 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C69512C00BF for ; Mon, 22 Jul 2013 02:25:47 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755892Ab3GUQZn (ORCPT ); Sun, 21 Jul 2013 12:25:43 -0400 Received: from mail-gg0-f181.google.com ([209.85.161.181]:41081 "EHLO mail-gg0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755722Ab3GUQZm (ORCPT ); Sun, 21 Jul 2013 12:25:42 -0400 Received: by mail-gg0-f181.google.com with SMTP id r4so1824868ggn.40 for ; Sun, 21 Jul 2013 09:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=iyGfOG3nju7tUnZLSfPCdNyVV+Xe1bj24VqcUJVdtqg=; b=PDLQiOzyALM1BhpG44H+k3R607fVpbPmUCGiU/FEFf1DoAFq3a/Cr9uZath7Q7SSUk Z2cI+2qyyrrDiOa7fua/vtAor/OYeldz97CxsIZALnQSHbK9OSlsdMfaithO+QL1ZoOD /WtOnXqxeDaaLo0ppZUgUDNg+bHOtaf3ICk7YRMmvMnmfvbjaaQBdp5+go/NjAdnAfer JPsymrLjNSG5tMiIywmZJTipj64e+drfShXyK5Bnh3opGWNx5y782h8xA+w2DOdoQE/p XLKl9GJW7/CdsPVUCrEgtpOkio0+KzSD9K9CQ5dkONkQEIDvcOskpHeu2031aInf91zp UaPQ== X-Received: by 10.236.49.41 with SMTP id w29mr12047983yhb.152.1374423941885; Sun, 21 Jul 2013 09:25:41 -0700 (PDT) Received: from localhost.localdomain ([189.5.19.145]) by mx.google.com with ESMTPSA id i27sm34053395yhj.24.2013.07.21.09.25.40 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 21 Jul 2013 09:25:41 -0700 (PDT) From: Fabio Estevam To: davem@davemloft.net Cc: kernel@pengutronix.de, Frank.Li@freescale.com, shawn.guo@linaro.org, netdev@vger.kernel.org, Fabio Estevam Subject: [PATCH 5/6] fec: Remove unneeded check in platform_get_resource() Date: Sun, 21 Jul 2013 13:25:03 -0300 Message-Id: <1374423904-2668-6-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1374423904-2668-1-git-send-email-festevam@gmail.com> References: <1374423904-2668-1-git-send-email-festevam@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam As devm_ioremap_resource() is used, there is no need to explicitely check the return value from platform_get_resource(), as this is something that devm_ioremap_resource() takes care by itself. Also, place platform_get_resource() prior to devm_ioremap_resource() for better code readability. Signed-off-by: Fabio Estevam --- drivers/net/ethernet/freescale/fec_main.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index acc1850..03028c4 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -2033,10 +2033,6 @@ fec_probe(struct platform_device *pdev) if (of_id) pdev->id_entry = of_id->data; - r = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!r) - return -ENXIO; - /* Init network device */ ndev = alloc_etherdev(sizeof(struct fec_enet_private)); if (!ndev) @@ -2054,6 +2050,7 @@ fec_probe(struct platform_device *pdev) fep->pause_flag |= FEC_PAUSE_FLAG_AUTONEG; #endif + r = platform_get_resource(pdev, IORESOURCE_MEM, 0); fep->hwp = devm_ioremap_resource(&pdev->dev, r); if (IS_ERR(fep->hwp)) { ret = PTR_ERR(fep->hwp);