From patchwork Wed Jun 19 15:34:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dean Jenkins X-Patchwork-Id: 252597 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A955A2C016F for ; Thu, 20 Jun 2013 01:41:37 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756991Ab3FSPld (ORCPT ); Wed, 19 Jun 2013 11:41:33 -0400 Received: from cpc6-farn7-2-0-cust119.6-2.cable.virginmedia.com ([81.110.26.120]:37739 "EHLO localhost.localdomain" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756954Ab3FSPlb (ORCPT ); Wed, 19 Jun 2013 11:41:31 -0400 Received: by localhost.localdomain (Postfix, from userid 500) id C936044205C; Wed, 19 Jun 2013 16:34:31 +0100 (BST) From: Dean Jenkins To: davem@davemloft.net, netdev@vger.kernel.org Subject: [PATCH 4/5] SLIP: Add error message for xleft non-zero Date: Wed, 19 Jun 2013 16:34:30 +0100 Message-Id: <1371656071-27754-5-git-send-email-Dean_Jenkins@mentor.com> X-Mailer: git-send-email 1.8.1.5 In-Reply-To: <1371656071-27754-1-git-send-email-Dean_Jenkins@mentor.com> References: <1371656071-27754-1-git-send-email-Dean_Jenkins@mentor.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add a printk to show when xleft is non-zero in sl_encaps. The idea is to see whether a previous SLIP frame failed to be fully transmitted. Signed-off-by: Dean Jenkins --- drivers/net/slip/slip.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/slip/slip.c b/drivers/net/slip/slip.c index f7303e0..e2eff84 100644 --- a/drivers/net/slip/slip.c +++ b/drivers/net/slip/slip.c @@ -395,6 +395,10 @@ static void sl_encaps(struct slip *sl, unsigned char *icp, int len) #endif count = slip_esc(p, sl->xbuff, len); + if (sl->xleft) + printk(KERN_ERR "%s: ERROR: xleft is non-zero %d\n", + __func__, sl->xleft); + /* ensure xleft set by the previous SLIP frame is zero for this frame * otherwise slip_write_wakeup() can cause a recursive loop. */