From patchwork Wed Jun 12 11:59:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yuval Mintz X-Patchwork-Id: 250746 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 526402C0099 for ; Wed, 12 Jun 2013 22:00:19 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754628Ab3FLMAN (ORCPT ); Wed, 12 Jun 2013 08:00:13 -0400 Received: from mms1.broadcom.com ([216.31.210.17]:4740 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573Ab3FLMAL (ORCPT ); Wed, 12 Jun 2013 08:00:11 -0400 Received: from [10.9.208.53] by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Wed, 12 Jun 2013 04:56:21 -0700 X-Server-Uuid: 06151B78-6688-425E-9DE2-57CB27892261 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS06.corp.ad.broadcom.com (10.9.208.53) with Microsoft SMTP Server (TLS) id 14.1.438.0; Wed, 12 Jun 2013 05:00:01 -0700 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.1.438.0; Wed, 12 Jun 2013 05:00:01 -0700 Received: from lb-tlvb-yuvalmin.il.broadcom.com ( lb-tlvb-yuvalmin.il.broadcom.com [10.185.6.94]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 80101F2D75; Wed, 12 Jun 2013 04:59:59 -0700 (PDT) From: "Yuval Mintz" To: bhutchings@solarflare.com cc: netdev@vger.kernel.org, "Yuval Mintz" Subject: [PATCH] Ethtool: Free memory leak in do_sprivflags() Date: Wed, 12 Jun 2013 14:59:58 +0300 Message-ID: <1371038398-15934-1-git-send-email-yuvalmin@broadcom.com> X-Mailer: git-send-email 1.8.1.227.g44fe835 MIME-Version: 1.0 X-WSS-ID: 7DA6BE6F31W35211956-01-01 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org cmdline is allocated for usage in parse_generic_cmdline(), but is not released after its final usage. Signed-off-by: Yuval Mintz --- ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ethtool.c b/ethtool.c index 8cc10b5..b80494d 100644 --- a/ethtool.c +++ b/ethtool.c @@ -3521,6 +3521,7 @@ static int do_sprivflags(struct cmd_context *ctx) cmdline[i].seen_val = &seen_flags; } parse_generic_cmdline(ctx, &any_changed, cmdline, strings->len); + free(cmdline); flags.cmd = ETHTOOL_GPFLAGS; if (send_ioctl(ctx, &flags)) {