Message ID | 1371038398-15934-1-git-send-email-yuvalmin@broadcom.com |
---|---|
State | Not Applicable, archived |
Delegated to: | David Miller |
Headers | show |
On Wed, 2013-06-12 at 14:59 +0300, Yuval Mintz wrote: > cmdline is allocated for usage in parse_generic_cmdline(), but is not > released after its final usage. > > Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com> Applied. Ben. > --- > ethtool.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ethtool.c b/ethtool.c > index 8cc10b5..b80494d 100644 > --- a/ethtool.c > +++ b/ethtool.c > @@ -3521,6 +3521,7 @@ static int do_sprivflags(struct cmd_context *ctx) > cmdline[i].seen_val = &seen_flags; > } > parse_generic_cmdline(ctx, &any_changed, cmdline, strings->len); > + free(cmdline); > > flags.cmd = ETHTOOL_GPFLAGS; > if (send_ioctl(ctx, &flags)) {
diff --git a/ethtool.c b/ethtool.c index 8cc10b5..b80494d 100644 --- a/ethtool.c +++ b/ethtool.c @@ -3521,6 +3521,7 @@ static int do_sprivflags(struct cmd_context *ctx) cmdline[i].seen_val = &seen_flags; } parse_generic_cmdline(ctx, &any_changed, cmdline, strings->len); + free(cmdline); flags.cmd = ETHTOOL_GPFLAGS; if (send_ioctl(ctx, &flags)) {
cmdline is allocated for usage in parse_generic_cmdline(), but is not released after its final usage. Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com> --- ethtool.c | 1 + 1 file changed, 1 insertion(+)