From patchwork Fri May 17 15:07:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Emilio_L=C3=B3pez?= X-Patchwork-Id: 244676 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1556A2C00D6 for ; Sat, 18 May 2013 02:02:40 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756111Ab3EQQCf (ORCPT ); Fri, 17 May 2013 12:02:35 -0400 Received: from zetta.elopez.com.ar ([199.30.59.35]:36617 "EHLO zetta.elopez.com.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755638Ab3EQQCe (ORCPT ); Fri, 17 May 2013 12:02:34 -0400 X-Greylist: delayed 2637 seconds by postgrey-1.27 at vger.kernel.org; Fri, 17 May 2013 12:02:34 EDT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=elopez.com.ar; s=mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=eWiIf36IFu0PZEwFgDcM76UUnqgQ7goYTjEV0puBmmA=; b=Yrwpt+khQKGWq170KCNZynfMob4gfNvw/XLb4cIk9IQPGCt1oy0JtY4B5ckLRWYguDTfJNgo7HNxLjyv9mD0ygPQcH1AsOT/Y2mVAY/2CRnCs4dMoVqRkL0A3jqIc+AOY8HFOatDSRAkbYNqz/SRgcBYVKiZVpNgcuK3bZp9RvhVlGnW4Z21rDmf/448Am5ER5h0tm9Sv6qkDInZtFcU9doBids/UUopHzYIFt97B29mlydGrCzp7/KwUsB/inZ0Cy+UOdyTmx3+EapE4DJmvG2zjKnyWRUYhrpCif84VQp+2Y7kmbAs0qD18NzKzIk2Ykxdbi4bsYF3HPDcNaPjjQ==; Received: from 201-212-118-238.prima.net.ar ([201.212.118.238] helo=desktop.lan) by zetta.elopez.com.ar with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) id 1UdMQi-0007WY-Nw; Fri, 17 May 2013 12:18:49 -0300 From: =?UTF-8?q?Emilio=20L=C3=B3pez?= To: davem@davemloft.net Cc: netdev@vger.kernel.org, , =?UTF-8?q?Emilio=20L=C3=B3pez?= Subject: [PATCH 3/4] net: ethernet: davicom: dm9000: initialize variables directly Date: Fri, 17 May 2013 12:07:47 -0300 Message-Id: <1368803268-27698-3-git-send-email-emilio@elopez.com.ar> X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <1368803268-27698-1-git-send-email-emilio@elopez.com.ar> References: <1368803268-27698-1-git-send-email-emilio@elopez.com.ar> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Clean up the code a bit to initialize the variables directly when defining them. Signed-off-by: Emilio López --- Please note that this patch is untested. drivers/net/ethernet/davicom/dm9000.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/net/ethernet/davicom/dm9000.c b/drivers/net/ethernet/davicom/dm9000.c index 9105465..e4ed05e 100644 --- a/drivers/net/ethernet/davicom/dm9000.c +++ b/drivers/net/ethernet/davicom/dm9000.c @@ -827,7 +827,7 @@ dm9000_hash_table_unlocked(struct net_device *dev) struct netdev_hw_addr *ha; int i, oft; u32 hash_val; - u16 hash_table[4]; + u16 hash_table[4] = {0, 0, 0, 0x8000}; /* broadcast address */ u8 rcr = RCR_DIS_LONG | RCR_DIS_CRC | RCR_RXEN; dm9000_dbg(db, 1, "entering %s\n", __func__); @@ -835,13 +835,6 @@ dm9000_hash_table_unlocked(struct net_device *dev) for (i = 0, oft = DM9000_PAR; i < 6; i++, oft++) iow(db, oft, dev->dev_addr[i]); - /* Clear Hash Table */ - for (i = 0; i < 4; i++) - hash_table[i] = 0x0; - - /* broadcast address */ - hash_table[3] = 0x8000; - if (dev->flags & IFF_PROMISC) rcr |= RCR_PRMSC;