| Message ID | 1368803268-27698-1-git-send-email-emilio@elopez.com.ar |
|---|---|
| State | Superseded, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Emilio López <emilio@elopez.com.ar> Date: Fri, 17 May 2013 12:07:45 -0300 > Clean up the code a bit to initialize the variables directly when > defining them. > > Signed-off-by: Emilio López <emilio@elopez.com.ar> Poorly styled, should be: u16 hash_table[4] = { 0 }; -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/sun/sunbmac.c b/drivers/net/ethernet/sun/sunbmac.c index 0549759..aabb40a 100644 --- a/drivers/net/ethernet/sun/sunbmac.c +++ b/drivers/net/ethernet/sun/sunbmac.c @@ -1017,10 +1017,7 @@ static void bigmac_set_multicast(struct net_device *dev) tmp |= BIGMAC_RXCFG_PMISC; sbus_writel(tmp, bregs + BMAC_RXCFG); } else { - u16 hash_table[4]; - - for (i = 0; i < 4; i++) - hash_table[i] = 0; + u16 hash_table[4] = {0}; netdev_for_each_mc_addr(ha, dev) { crc = ether_crc_le(6, ha->addr);
Clean up the code a bit to initialize the variables directly when defining them. Signed-off-by: Emilio López <emilio@elopez.com.ar> --- Please note that this patch is untested. drivers/net/ethernet/sun/sunbmac.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)