From patchwork Thu Apr 25 20:29:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tedheadster X-Patchwork-Id: 239594 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9814A2C00CC for ; Fri, 26 Apr 2013 06:29:26 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933046Ab3DYU3L (ORCPT ); Thu, 25 Apr 2013 16:29:11 -0400 Received: from mail-qe0-f42.google.com ([209.85.128.42]:54269 "EHLO mail-qe0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933037Ab3DYU3J (ORCPT ); Thu, 25 Apr 2013 16:29:09 -0400 Received: by mail-qe0-f42.google.com with SMTP id 1so23724qee.29 for ; Thu, 25 Apr 2013 13:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=7CnX3AF7pfu0ncNyIBI/DOkJgWWAzNUY+fiYABeWhIo=; b=WAQw7oXh4//6RDKOVXakkG4q2gz2DDdxkUBmkNHjRsErFNz3BhJhKvVMiioNK4MGsr ABLlbDcKIjzFIZDK4Esu6Ht7ETzQFpNzypW6QGDTz5Ba8FISQ6ckjq7AQ4Y1LYtxuStE gK8qkolDK9dKI4MQmi68C6+CIjLc7LTylTabzLksHz7iz4b/ObMLvMkw3Vujlvvd04Wr ZIbXUs0nraMYRPVPiydlJ/6pN/bmtzjt7aOtGv6IkeASEo/83IjxpB48JYmWkM/l0mE2 bYnumZjGOMzWKAlvJNCOv+LiuEqW1hPouWS7eesZaNePyoMx10OM7gS1yG4PsrqWP2Mx ZqeQ== X-Received: by 10.49.82.133 with SMTP id i5mr43777517qey.43.1366921749182; Thu, 25 Apr 2013 13:29:09 -0700 (PDT) Received: from localhost.localdomain (pool-74-103-8-160.bltmmd.fios.verizon.net. [74.103.8.160]) by mx.google.com with ESMTPSA id n5sm6353218qav.2.2013.04.25.13.29.07 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 25 Apr 2013 13:29:08 -0700 (PDT) From: Matthew Whitehead To: netdev@vger.kernel.org Cc: Matthew Whitehead Subject: [PATCH] 3c509.c: call SET_NETDEV_DEV for all device types (ISA/ISAPnP/EISA) Date: Thu, 25 Apr 2013 16:29:03 -0400 Message-Id: <1366921743-6440-1-git-send-email-tedheadster@gmail.com> X-Mailer: git-send-email 1.7.2.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Matthew Whitehead The venerable 3c509 driver only sets its device parent in one case, the ISAPnP one. It does this with the SET_NETDEV_DEV function. It should register with the device hierarchy in two additional cases: standard (non-PnP) ISA and EISA. - Currently they appear here: /sys/devices/virtual/net/eth0 (standard ISA) /sys/devices/virtual/net/eth1 (EISA) - Rather, they should instead be here: /sys/devices/isa/3c509.0/net/eth0 (standard ISA) /sys/devices/pci0000:00/0000:00:07.0/00:04/net/eth1 (EISA) Tested on ISA and EISA boards. --- drivers/net/ethernet/3com/3c509.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/3com/3c509.c b/drivers/net/ethernet/3com/3c509.c index f36ff99..adb4bf5 100644 --- a/drivers/net/ethernet/3com/3c509.c +++ b/drivers/net/ethernet/3com/3c509.c @@ -306,6 +306,7 @@ static int el3_isa_match(struct device *pdev, unsigned int ndev) if (!dev) return -ENOMEM; + SET_NETDEV_DEV(dev, pdev); netdev_boot_setup_check(dev); if (!request_region(ioaddr, EL3_IO_EXTENT, "3c509-isa")) { @@ -595,6 +596,7 @@ static int __init el3_eisa_probe (struct device *device) return -ENOMEM; } + SET_NETDEV_DEV(dev, device); netdev_boot_setup_check(dev); el3_dev_fill(dev, phys_addr, ioaddr, irq, if_port, EL3_EISA);