From patchwork Sat Apr 13 17:25:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 236372 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 653B92C0085 for ; Sun, 14 Apr 2013 03:25:53 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754135Ab3DMRZu (ORCPT ); Sat, 13 Apr 2013 13:25:50 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:47697 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753720Ab3DMRZt (ORCPT ); Sat, 13 Apr 2013 13:25:49 -0400 Received: by mail-gh0-f174.google.com with SMTP id g10so268791ghb.33 for ; Sat, 13 Apr 2013 10:25:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=MfMflZg0IZYyMWy7zKGggXCH6ZoKmx/2gHM6okHSg+k=; b=wSKpY8EDllWxBiOUcYFldTN1PeHScnoDbAHrjcTXkD0nN8eonnKX0kSw6Gt73XEzC+ Q6S/5LU0Q+4RzoOfGr0XjdcxCTwI9R7y1zdOVjsKYSj+B8bUKN9UhWV1pAlOy+CRUOCv cjSr+CNT+lTldRnGy1SuAdBUpBPxzM+Bz/xR7RKjYmZfknR+Sbj1HT7NP1EyqWg8DhOL I26OZjKOs03imhD2gv0VrU2hCJc1aLspWI88YRJs7v3aQNJ/cu4gpXZFLgQrIfPf2jd6 LIaJEi2XwmmihHLslnG30fgu0et2RdyFzxjxZzpsvtkPB267hO6RnoOSHiOQQ3J+ioDd pw5Q== X-Received: by 10.236.0.107 with SMTP id 71mr796511yha.177.1365873948807; Sat, 13 Apr 2013 10:25:48 -0700 (PDT) Received: from localhost.localdomain ([187.64.220.204]) by mx.google.com with ESMTPS id a24sm15375455yhj.23.2013.04.13.10.25.46 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 13 Apr 2013 10:25:48 -0700 (PDT) From: Fabio Estevam To: davem@davemloft.net Cc: Frank.Li@freescale.com, netdev@vger.kernel.org, joe@perches.com, Fabio Estevam Subject: [PATCH v2] fec: Fix PHC device log Date: Sat, 13 Apr 2013 14:25:36 -0300 Message-Id: <1365873936-9521-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam Currently when booting a mx6 device we get the following on boot: registered PHC device on eth%d Fix it by printing the network device name only after it gets registered, so that the following can be read now: fec 2188000.ethernet eth0: registered PHC device 0 Signed-off-by: Fabio Estevam --- Changes since v1: - Use netdev_info - Only print the interface name after it gets registered. drivers/net/ethernet/freescale/fec_main.c | 3 +++ drivers/net/ethernet/freescale/fec_ptp.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 806a56d..e8858a6 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1858,6 +1858,9 @@ fec_probe(struct platform_device *pdev) if (ret) goto failed_register; + if (fep->bufdesc_ex && fep->ptp_clock) + netdev_info(ndev, "registered PHC device %d\n", fep->dev_id); + return 0; failed_register: diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 1f17ca0..e040c8b 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -379,7 +379,5 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev) if (IS_ERR(fep->ptp_clock)) { fep->ptp_clock = NULL; pr_err("ptp_clock_register failed\n"); - } else { - pr_info("registered PHC device on %s\n", ndev->name); } }