From patchwork Tue Mar 5 16:09:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Hurley X-Patchwork-Id: 225071 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 255CF2C0333 for ; Wed, 6 Mar 2013 03:11:17 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756872Ab3CEQJ5 (ORCPT ); Tue, 5 Mar 2013 11:09:57 -0500 Received: from mailout01.c08.mtsvc.net ([205.186.168.189]:41137 "EHLO mailout01.c08.mtsvc.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756742Ab3CEQJu (ORCPT ); Tue, 5 Mar 2013 11:09:50 -0500 Received: from n22.c08.mtsvc.net ([205.186.176.22]) by mailout01.c08.mtsvc.net with esmtp (Exim 4.72) (envelope-from ) id 1UCuQs-0006y4-2B; Tue, 05 Mar 2013 08:09:38 -0800 Received: from 68-189-242-29.dhcp.oxfr.ma.charter.com ([68.189.242.29]:43839 helo=thor.lan) by n22.c08.mtsvc.net with esmtpsa (TLS1.1:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80.1) (envelope-from ) id 1UCuQq-0001tA-IU; Tue, 05 Mar 2013 08:09:37 -0800 From: Peter Hurley To: David Miller , Samuel Ortiz Cc: Sasha Levin , Greg Kroah-Hartman , netdev@vger.kernel.org, Jiri Slaby , linux-kernel@vger.kernel.org, Peter Hurley Subject: [PATCH 3/4] net/irda: Use barrier to set task state Date: Tue, 5 Mar 2013 11:09:06 -0500 Message-Id: <1362499747-4262-4-git-send-email-peter@hurleysoftware.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1362499747-4262-1-git-send-email-peter@hurleysoftware.com> References: <1362371063.3221.185.camel@thor.lan> <1362499747-4262-1-git-send-email-peter@hurleysoftware.com> X-Authenticated-User: 125194 peter@hurleysoftware.com X-Spam-Status: "score=-0.9 tests=ALL_TRUSTED, TVD_RCVD_IP version=3.3.1 cmae=v=1.1 cv=lrjH+2xzIqj4PtBndNBiF3kNcDPTgJYy5MO9fqj9h9k= c=1 sm=0 a=e6Q0-yfCVbEA:10 a=lF0tP7JmhmIA:10 a=hykYmh53AP4XJEdaM13vyQ==:17 a=xGRsDScCAAAA:8 a=6Cv156VgFXUNZvNSkAcA:9 a=A4LuvFU5fKoA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117" X-Spam-Level: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Without a memory and compiler barrier, the task state change can migrate relative to the condition testing in a blocking loop. However, the task state change must be visible across all cpus prior to testing those conditions. Failing to do this can result in the familiar 'lost wakeup' and this task will hang until killed. Signed-off-by: Peter Hurley --- net/irda/ircomm/ircomm_tty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c index d282bbe..522543d 100644 --- a/net/irda/ircomm/ircomm_tty.c +++ b/net/irda/ircomm/ircomm_tty.c @@ -324,7 +324,7 @@ static int ircomm_tty_block_til_ready(struct ircomm_tty_cb *self, if (tty->termios.c_cflag & CBAUD) tty_port_raise_dtr_rts(port); - current->state = TASK_INTERRUPTIBLE; + set_current_state(TASK_INTERRUPTIBLE); if (tty_hung_up_p(filp) || !test_bit(ASYNCB_INITIALIZED, &port->flags)) {