From patchwork Mon Mar 4 12:58:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 224714 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5DCEA2C031E for ; Tue, 5 Mar 2013 00:01:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758177Ab3CDNAD (ORCPT ); Mon, 4 Mar 2013 08:00:03 -0500 Received: from mail-da0-f50.google.com ([209.85.210.50]:49928 "EHLO mail-da0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758119Ab3CDNAA (ORCPT ); Mon, 4 Mar 2013 08:00:00 -0500 Received: by mail-da0-f50.google.com with SMTP id h15so2501532dan.23 for ; Mon, 04 Mar 2013 04:59:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=/9h6HJPlIzeqcgjnnTydqkftlAankRyFn5tN8kurdj0=; b=ob4EnYNoc+/abZTb+mKBQD1wJAQBqY3le9/fcisFC3do6s3wrPs8fEn/ysjtdkov/v M03BkzimimSaBBM40mzfhx9WNA6oFzFgQAP4YFxbHilGlF5I4RIEDlW48qdRyyNLoNIG H21YJJZWLe+XL8vdk+jc/uBbGOKmzlukpS0LWiRoOFE+tPUpL2wDbgz9llN3ZoHo2AOl pvQRs+S78csL2ByvJ60ibH2jKRWghzWMVt346Q74aWRPDXriP1rg135EOQEizhK4zHxv N/2Iy5G9xHEVS9sMegXLJh73ljzxGz4tjplUuBoG4QI3SkSP4i+FMAedcYxsrXMASQe8 QO8g== X-Received: by 10.66.120.136 with SMTP id lc8mr31360652pab.194.1362401999708; Mon, 04 Mar 2013 04:59:59 -0800 (PST) Received: from localhost.localdomain (p2126-ipbf3106hodogaya.kanagawa.ocn.ne.jp. [114.149.157.126]) by mx.google.com with ESMTPS id t6sm23836060paz.11.2013.03.04.04.59.57 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 04 Mar 2013 04:59:58 -0800 (PST) From: Akinobu Mita To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: Akinobu Mita , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH -v3 21/23] net/core: remove duplicate statements by do-while loop Date: Mon, 4 Mar 2013 21:58:29 +0900 Message-Id: <1362401911-14074-22-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1362401911-14074-1-git-send-email-akinobu.mita@gmail.com> References: <1362401911-14074-1-git-send-email-akinobu.mita@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove duplicate statements by using do-while loop instead of while loop. - A; - while (e) { + do { A; - } + } while (e); Signed-off-by: Akinobu Mita Cc: "David S. Miller" Cc: netdev@vger.kernel.org --- No change from v2 net/core/pktgen.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 4582275..5c21742 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2396,18 +2396,15 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev) __be32 s; if (pkt_dev->flags & F_IPDST_RND) { - t = prandom_u32() % (imx - imn) + imn; - s = htonl(t); - - while (ipv4_is_loopback(s) || - ipv4_is_multicast(s) || - ipv4_is_lbcast(s) || - ipv4_is_zeronet(s) || - ipv4_is_local_multicast(s)) { + do { t = prandom_u32() % (imx - imn) + imn; s = htonl(t); - } + } while (ipv4_is_loopback(s) || + ipv4_is_multicast(s) || + ipv4_is_lbcast(s) || + ipv4_is_zeronet(s) || + ipv4_is_local_multicast(s)); pkt_dev->cur_daddr = s; } else { t = ntohl(pkt_dev->cur_daddr);