From patchwork Sat Jan 5 21:19:24 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xi Wang X-Patchwork-Id: 209699 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 948002C0080 for ; Sun, 6 Jan 2013 08:19:36 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755878Ab3AEVTc (ORCPT ); Sat, 5 Jan 2013 16:19:32 -0500 Received: from mail-vc0-f176.google.com ([209.85.220.176]:46930 "EHLO mail-vc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755850Ab3AEVTb (ORCPT ); Sat, 5 Jan 2013 16:19:31 -0500 Received: by mail-vc0-f176.google.com with SMTP id fo13so17762188vcb.35 for ; Sat, 05 Jan 2013 13:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=of28dfhwz4/Xo982ggzZYMkZFP/U3lLQWzrCcCnPWYo=; b=T0RT4hVVmpOE9tGMX3jZsrrgc6HeOwGsKxQbCWq1qs/nXoave8qD/bN0k8cPXCtEHY a/YuUFH9LwzwkIbBAIs1944IajH0w1cpdA122eF137FCIZ/zR2zeHv739L0CpThUNOX0 RQo8Tq/PRozCO09hK5xQ2cWNLomCEs4ntGG9U54rel1q6gMy5nJaAM7In4OONdr1jr/d WQqcg7kdFX+9AUTYOdDkgb+XGpAGn1MGVD0Wk/1zK1T96QNQj4V5yGPZvdJ+VRdZnhJY CTnddFRhXNkIFohsyIL/YuAtlL0OVlmvcA7I3pu2Vt5mt1eRgyYwkpJquSI5QKbeDLtv YVcA== X-Received: by 10.220.154.148 with SMTP id o20mr79710200vcw.54.1357420770242; Sat, 05 Jan 2013 13:19:30 -0800 (PST) Received: from hchen.lcs.mit.edu (26-4-178.dynamic.csail.mit.edu. [18.26.4.178]) by mx.google.com with ESMTPS id dp6sm46061826vec.11.2013.01.05.13.19.27 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 05 Jan 2013 13:19:28 -0800 (PST) From: Xi Wang To: "David S. Miller" Cc: netdev@vger.kernel.org, Xi Wang Subject: [PATCH] ipv4: fix NULL checking in devinet_ioctl() Date: Sat, 5 Jan 2013 16:19:24 -0500 Message-Id: <1357420764-12381-1-git-send-email-xi.wang@gmail.com> X-Mailer: git-send-email 1.7.10.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The NULL pointer check `!ifa' should come before its first use. Signed-off-by: Xi Wang Acked-by: Eric Dumazet --- net/ipv4/devinet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index cc06a47..a8e4f26 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -823,9 +823,9 @@ int devinet_ioctl(struct net *net, unsigned int cmd, void __user *arg) if (!ifa) { ret = -ENOBUFS; ifa = inet_alloc_ifa(); - INIT_HLIST_NODE(&ifa->hash); if (!ifa) break; + INIT_HLIST_NODE(&ifa->hash); if (colon) memcpy(ifa->ifa_label, ifr.ifr_name, IFNAMSIZ); else