From patchwork Thu Jan 3 12:19:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akinobu Mita X-Patchwork-Id: 209236 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4426D2C007A for ; Thu, 3 Jan 2013 23:22:12 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753663Ab3ACMVz (ORCPT ); Thu, 3 Jan 2013 07:21:55 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:53372 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753451Ab3ACMU3 (ORCPT ); Thu, 3 Jan 2013 07:20:29 -0500 Received: by mail-pa0-f51.google.com with SMTP id fb11so8633023pad.10 for ; Thu, 03 Jan 2013 04:20:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=R5iUqviJN2rbxJjHutZPLF3Az25j0wLbBXYvW3lIca0=; b=nw0SnmEkX2F6d53tKnP9z6Rv0KGxAKJiZawotho2FxYP3j/561yRcP0YvFCrxnVTyX zgiyuo/EO835FP0hDRsmpce3FS+I/Sg9TjEvME5RwzAW78rU81OdiLx7N02cR1UfsaPW ykBpl1jIGAq6V/NXtdnKOI0G9SwiRTFWHqnQHIY1inW0lC4/BMpUMS7nodgg6uTCEj4t lcQYRD5TQK/L4I4GBKR5Cwm4FTUQIW3x70sQamnVhnI68GFQFua+91pnaK+huB0nIVEq R2n702Rm5K2WwMFUf4Kdz1FX86h7VkFKZT/mrazBzQyG+cC5/tNDT2cRfWlwZmbCE5iM EcMQ== X-Received: by 10.68.248.74 with SMTP id yk10mr153521395pbc.86.1357215628492; Thu, 03 Jan 2013 04:20:28 -0800 (PST) Received: from localhost.localdomain (p2126-ipbf3106hodogaya.kanagawa.ocn.ne.jp. [114.149.157.126]) by mx.google.com with ESMTPS id qn3sm28095334pbb.56.2013.01.03.04.20.26 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 03 Jan 2013 04:20:27 -0800 (PST) From: Akinobu Mita To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org Cc: Akinobu Mita , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH -v2 24/26] net/core: remove duplicate statements by do-while loop Date: Thu, 3 Jan 2013 21:19:20 +0900 Message-Id: <1357215562-6288-25-git-send-email-akinobu.mita@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1357215562-6288-1-git-send-email-akinobu.mita@gmail.com> References: <1357215562-6288-1-git-send-email-akinobu.mita@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove duplicate statements by using do-while loop instead of while loop. - A; - while (e) { + do { A; - } + } while (e); Signed-off-by: Akinobu Mita Cc: "David S. Miller" Cc: netdev@vger.kernel.org --- No change from v1 net/core/pktgen.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index d23ec86..48a3a29 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -2379,18 +2379,15 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev) __be32 s; if (pkt_dev->flags & F_IPDST_RND) { - t = prandom_u32() % (imx - imn) + imn; - s = htonl(t); - - while (ipv4_is_loopback(s) || - ipv4_is_multicast(s) || - ipv4_is_lbcast(s) || - ipv4_is_zeronet(s) || - ipv4_is_local_multicast(s)) { + do { t = prandom_u32() % (imx - imn) + imn; s = htonl(t); - } + } while (ipv4_is_loopback(s) || + ipv4_is_multicast(s) || + ipv4_is_lbcast(s) || + ipv4_is_zeronet(s) || + ipv4_is_local_multicast(s)); pkt_dev->cur_daddr = s; } else { t = ntohl(pkt_dev->cur_daddr);