From patchwork Mon Oct 8 18:34:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Ceuleers X-Patchwork-Id: 190090 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6A9AC2C030D for ; Tue, 9 Oct 2012 05:35:10 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754572Ab2JHSfJ (ORCPT ); Mon, 8 Oct 2012 14:35:09 -0400 Received: from mailrelay012.isp.belgacom.be ([195.238.6.179]:65216 "EHLO mailrelay012.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752582Ab2JHSfH (ORCPT ); Mon, 8 Oct 2012 14:35:07 -0400 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAJwbc1Bthdhr/2dsb2JhbABFvy+BCIIgAQEBBAECdhAYCDEhBy8GE4dzAxMHsCMNiVSKaYZ2A5M+VwGHWYUfhQuCbw Received: from unknown (HELO zotac.xperim.be) ([109.133.216.107]) by relay.skynet.be with ESMTP; 08 Oct 2012 20:35:05 +0200 Received: from mordor.xperim.be (mordor.xperim.be [192.168.1.44]) by zotac.xperim.be (8.14.4/8.14.4/Debian-2ubuntu2) with ESMTP id q98IYop1007239; Mon, 8 Oct 2012 20:34:51 +0200 From: Jan Ceuleers To: "David S. Miller" Cc: netdev@vger.kernel.org, Graham Gower , Stephen Hemminger Subject: [PATCH v2] skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard Date: Mon, 8 Oct 2012 20:34:50 +0200 Message-Id: <1349721290-16374-1-git-send-email-jan.ceuleers@computer.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1349715275-12730-1-git-send-email-jan.ceuleers@computer.org> References: <1349715275-12730-1-git-send-email-jan.ceuleers@computer.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Graham Gower Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive packets on a system with >4gb ram unless a 32bit DMA mask is used. This issue has been around for years and a fix was sent 3.5 years ago, but there was some debate as to whether it should instead be fixed as a PCI quirk. http://www.spinics.net/lists/netdev/msg88670.html However, 18 months later a similar workaround was introduced for another chipset exhibiting the same problem. http://www.spinics.net/lists/netdev/msg142287.html Signed-off-by: Graham Gower Signed-off-by: Jan Ceuleers Acked-by: Stephen Hemminger --- I am resubmitting Graham's v4 patch hoping that doing so will avoid further frustration while still getting this fix into the tree. I have not tested this; I don't have the hardware. It compiles though. v2: Fixed whitespace error drivers/net/ethernet/marvell/skge.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c index 5a30bf8..05b3c83 100644 --- a/drivers/net/ethernet/marvell/skge.c +++ b/drivers/net/ethernet/marvell/skge.c @@ -4153,6 +4153,13 @@ static struct dmi_system_id skge_32bit_dma_boards[] = { DMI_MATCH(DMI_BOARD_NAME, "nForce"), }, }, + { + .ident = "ASUS P5NSLI", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."), + DMI_MATCH(DMI_BOARD_NAME, "P5NSLI") + }, + }, {} };