From patchwork Tue Sep 4 14:21:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Neukum X-Patchwork-Id: 181591 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D48CF2C00A0 for ; Wed, 5 Sep 2012 00:30:06 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757246Ab2IDOaF (ORCPT ); Tue, 4 Sep 2012 10:30:05 -0400 Received: from smtp-out002.kontent.com ([81.88.40.216]:36747 "EHLO smtp-out002.kontent.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757201Ab2IDOaD (ORCPT ); Tue, 4 Sep 2012 10:30:03 -0400 X-Greylist: delayed 404 seconds by postgrey-1.27 at vger.kernel.org; Tue, 04 Sep 2012 10:30:03 EDT Received: from localhost.localdomain (p4FFB0A97.dip.t-dialin.net [79.251.10.151]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: neukum_org@smtp-out002.kontent.com) by smtp-out002.kontent.com (Postfix) with ESMTPSA id 80DAB100381C0; Tue, 4 Sep 2012 16:23:18 +0200 (CEST) From: Oliver Neukum To: davem@davemloft.net, netdev@vger.kernel.org Cc: Oliver Neukum , Oliver Neukum Subject: [PATCH] usbnet: drop unneeded check for NULL Date: Tue, 4 Sep 2012 16:21:54 +0200 Message-Id: <1346768514-19823-1-git-send-email-oliver@neukum.org> X-Mailer: git-send-email 1.7.7 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org usbnet_start_xmit() is always called with a valid skb Signed-off-by: Oliver Neukum --- drivers/net/usb/usbnet.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 8531c1c..5234d20 100644 --- a/drivers/net/usb/usbnet.c +++ b/drivers/net/usb/usbnet.c @@ -1092,8 +1092,7 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb, unsigned long flags; int retval; - if (skb) - skb_tx_timestamp(skb); + skb_tx_timestamp(skb); // some devices want funky USB-level framing, for // win32 driver (usually) and/or hardware quirks