From patchwork Wed Aug 22 07:38:53 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lutz Jaenicke X-Patchwork-Id: 179254 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 672742C008A for ; Wed, 22 Aug 2012 17:39:52 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758660Ab2HVHjX (ORCPT ); Wed, 22 Aug 2012 03:39:23 -0400 Received: from home.innominate.com ([77.245.32.75]:40099 "EHLO home.innominate.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756970Ab2HVHjT (ORCPT ); Wed, 22 Aug 2012 03:39:19 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by home.innominate.com (Postfix) with ESMTP id E251623236; Wed, 22 Aug 2012 09:39:18 +0200 (CEST) Received: from home.innominate.com ([127.0.0.1]) by localhost (innominate.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ML8vPAl8crR9; Wed, 22 Aug 2012 09:39:18 +0200 (CEST) Received: from lutz.bln.innominate.local (lutz.bln.innominate.local [10.1.0.160]) by home.innominate.com (Postfix) with ESMTP id C661223235; Wed, 22 Aug 2012 09:39:18 +0200 (CEST) Received: by lutz.bln.innominate.local (Postfix, from userid 1000) id BD5FF3B1; Wed, 22 Aug 2012 09:39:18 +0200 (CEST) From: Lutz Jaenicke To: netdev@vger.kernel.org Cc: Lutz Jaenicke Subject: [PATCH] iproute2: rtnl_wilddump_request: fix alignment for embedded platforms Date: Wed, 22 Aug 2012 09:38:53 +0200 Message-Id: <1345621133-23583-1-git-send-email-ljaenicke@innominate.com> X-Mailer: git-send-email 1.7.2.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Platforms have different alignment requirements which need to be fulfilled by the compiler. If the structure elements are already 4 byte (NLMGS_ALIGNTO) aligned by the compiler adding an explicit padding element (align_rta) is not allowed. Use __attribute__ ((aligned (NLMSG_ALIGNTO))) in order to achieve the required alignment. Experienced on ARM (xscale) with symptom netlink: 12 bytes leftover after parsing attributes Signed-off-by: Lutz Jaenicke --- lib/libnetlink.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/lib/libnetlink.c b/lib/libnetlink.c index 8e8c8b9..05701ef 100644 --- a/lib/libnetlink.c +++ b/lib/libnetlink.c @@ -94,10 +94,9 @@ int rtnl_wilddump_request(struct rtnl_handle *rth, int family, int type) struct { struct nlmsghdr nlh; struct rtgenmsg g; - __u16 align_rta; /* attribute has to be 32bit aligned */ struct rtattr ext_req; __u32 ext_filter_mask; - } req; + } req __attribute__ ((aligned (NLMSG_ALIGNTO))); memset(&req, 0, sizeof(req)); req.nlh.nlmsg_len = sizeof(req);