diff mbox

mISDN: Bugfix for layer2 fixed TEI mode

Message ID 1344075265-18999-1-git-send-email-keil@b1-systems.de
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Karsten Keil Aug. 4, 2012, 10:14 a.m. UTC
If a fixed TEI is used, the initial state of the layer 2 statmachine need to be
4 (TEI assigned). This was true only for Point to Point connections, but not
for the other fixed TEIs. It was not found before, because usually only the
TEI 0 is used as fixed TEI for PtP mode, but if you try X31 packet mode
connections with SAPI 16, TEI 1, it did fail.

Signed-off-by: Karsten Keil <keil@b1-systems.de>
Cc: <stable@vger.kernel.org> # 3.5.x
---
 drivers/isdn/mISDN/layer2.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

David Miller Aug. 6, 2012, 8:27 p.m. UTC | #1
From: Karsten Keil <keil@b1-systems.de>
Date: Sat,  4 Aug 2012 12:14:25 +0200

> If a fixed TEI is used, the initial state of the layer 2 statmachine need to be
> 4 (TEI assigned). This was true only for Point to Point connections, but not
> for the other fixed TEIs. It was not found before, because usually only the
> TEI 0 is used as fixed TEI for PtP mode, but if you try X31 packet mode
> connections with SAPI 16, TEI 1, it did fail.
> 
> Signed-off-by: Karsten Keil <keil@b1-systems.de>
> Cc: <stable@vger.kernel.org> # 3.5.x

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/isdn/mISDN/layer2.c b/drivers/isdn/mISDN/layer2.c
index 0dc8abc..949cabb 100644
--- a/drivers/isdn/mISDN/layer2.c
+++ b/drivers/isdn/mISDN/layer2.c
@@ -2222,7 +2222,7 @@  create_l2(struct mISDNchannel *ch, u_int protocol, u_long options, int tei,
 	InitWin(l2);
 	l2->l2m.fsm = &l2fsm;
 	if (test_bit(FLG_LAPB, &l2->flag) ||
-	    test_bit(FLG_PTP, &l2->flag) ||
+	    test_bit(FLG_FIXED_TEI, &l2->flag) ||
 	    test_bit(FLG_LAPD_NET, &l2->flag))
 		l2->l2m.state = ST_L2_4;
 	else