From patchwork Sun Jul 29 17:15:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karsten Keil X-Patchwork-Id: 173931 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C241F2C008F for ; Mon, 30 Jul 2012 03:22:29 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753334Ab2G2RVr (ORCPT ); Sun, 29 Jul 2012 13:21:47 -0400 Received: from mx1.b1-systems.de ([217.11.58.35]:47397 "EHLO mx1.b1-systems.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753322Ab2G2RVq (ORCPT ); Sun, 29 Jul 2012 13:21:46 -0400 Received: from pingi6.linux-pingi.de (p4FE606A0.dip0.t-ipconnect.de [79.230.6.160]) by mx1.b1-systems.de (Postfix) with ESMTPSA id 0518E4084; Sun, 29 Jul 2012 19:15:15 +0200 (CEST) From: Karsten Keil To: davem@davemloft.net Cc: netdev@vger.kernel.org, tobias.powalowski@googlemail.com Subject: [PATCH 1/1] mISDN: Bugfix only few bytes are transfered on a connection Date: Sun, 29 Jul 2012 19:15:13 +0200 Message-Id: <1343582113-14752-2-git-send-email-keil@b1-systems.de> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1343582113-14752-1-git-send-email-keil@b1-systems.de> References: <1343582113-14752-1-git-send-email-keil@b1-systems.de> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The test for the fillempty condition was wrong in one place. Changed the variable to the right boolean type. Signed-off-by: Karsten Keil --- drivers/isdn/hardware/mISDN/avmfritz.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/isdn/hardware/mISDN/avmfritz.c b/drivers/isdn/hardware/mISDN/avmfritz.c index c08fc60..fa6ca47 100644 --- a/drivers/isdn/hardware/mISDN/avmfritz.c +++ b/drivers/isdn/hardware/mISDN/avmfritz.c @@ -449,7 +449,8 @@ hdlc_fill_fifo(struct bchannel *bch) { struct fritzcard *fc = bch->hw; struct hdlc_hw *hdlc; - int count, fs, cnt = 0, idx, fillempty = 0; + int count, fs, cnt = 0, idx; + bool fillempty = false; u8 *p; u32 *ptr, val, addr; @@ -462,7 +463,7 @@ hdlc_fill_fifo(struct bchannel *bch) return; count = fs; p = bch->fill; - fillempty = 1; + fillempty = true; } else { count = bch->tx_skb->len - bch->tx_idx; if (count <= 0) @@ -477,7 +478,7 @@ hdlc_fill_fifo(struct bchannel *bch) hdlc->ctrl.sr.cmd |= HDLC_CMD_XME; } ptr = (u32 *)p; - if (fillempty) { + if (!fillempty) { pr_debug("%s.B%d: %d/%d/%d", fc->name, bch->nr, count, bch->tx_idx, bch->tx_skb->len); bch->tx_idx += count;