From patchwork Thu Jul 19 17:04:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Schmidt X-Patchwork-Id: 171988 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6475C2C00B6 for ; Fri, 20 Jul 2012 03:04:57 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711Ab2GSREy (ORCPT ); Thu, 19 Jul 2012 13:04:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31418 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313Ab2GSREx (ORCPT ); Thu, 19 Jul 2012 13:04:53 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6JH4mA6030849 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 19 Jul 2012 13:04:48 -0400 Received: from brian.englab.brq.redhat.com (brian.brq.redhat.com [10.34.26.27]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6JH4k2a022613; Thu, 19 Jul 2012 13:04:47 -0400 From: Michal Schmidt To: netdev@vger.kernel.org Cc: Ben Hutchings , Solarflare linux maintainers Subject: [PATCH] sfc: initialize dynamic sysfs attributes for lockdep Date: Thu, 19 Jul 2012 19:04:45 +0200 Message-Id: <1342717485-24034-1-git-send-email-mschmidt@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dynamically allocated sysfs attributes must be initialized using sysfs_attr_init(), otherwise lockdep complains: BUG: key
not in .data! Signed-off-by: Michal Schmidt Acked-by: Ben Hutchings --- drivers/net/ethernet/sfc/mcdi_mon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/sfc/mcdi_mon.c b/drivers/net/ethernet/sfc/mcdi_mon.c index fb7f65b..1d552f0 100644 --- a/drivers/net/ethernet/sfc/mcdi_mon.c +++ b/drivers/net/ethernet/sfc/mcdi_mon.c @@ -222,6 +222,7 @@ efx_mcdi_mon_add_attr(struct efx_nic *efx, const char *name, attr->index = index; attr->type = type; attr->limit_value = limit_value; + sysfs_attr_init(&attr->dev_attr.attr); attr->dev_attr.attr.name = attr->name; attr->dev_attr.attr.mode = S_IRUGO; attr->dev_attr.show = reader;