| Message ID | 1342033015-31442-1-git-send-email-fbl@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> -----Original Message----- > From: Flavio Leitner [mailto:fbl@redhat.com] > Sent: Thursday, July 12, 2012 12:27 AM > To: netdev > Cc: Sony Chacko; Rajesh Borundia; Flavio Leitner > Subject: [PATCH net-next] netxen: fix link notification order > > First update the adapter variables with the current speed and > mode before fire the notification. Otherwise, the get_settings() > may provide old values. > > Signed-off-by: Flavio Leitner <fbl@redhat.com> > --- > drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c > b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c > index b2c1b676..bc165f4 100644 > --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c > +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c > @@ -1437,8 +1437,6 @@ netxen_handle_linkevent(struct netxen_adapter > *adapter, nx_fw_msg_t *msg) > netdev->name, cable_len); > } > > - netxen_advert_link_change(adapter, link_status); > - > /* update link parameters */ > if (duplex == LINKEVENT_FULL_DUPLEX) > adapter->link_duplex = DUPLEX_FULL; > @@ -1447,6 +1445,8 @@ netxen_handle_linkevent(struct netxen_adapter > *adapter, nx_fw_msg_t *msg) > adapter->module_type = module; > adapter->link_autoneg = autoneg; > adapter->link_speed = link_speed; > + > + netxen_advert_link_change(adapter, link_status); > } > > static void > -- > 1.7.10.4 > Acked-by: Rajesh Borundia <rajesh.borundia@qlogic.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Flavio Leitner <fbl@redhat.com> Date: Wed, 11 Jul 2012 15:56:55 -0300 > First update the adapter variables with the current speed and > mode before fire the notification. Otherwise, the get_settings() > may provide old values. > > Signed-off-by: Flavio Leitner <fbl@redhat.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c index b2c1b676..bc165f4 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c @@ -1437,8 +1437,6 @@ netxen_handle_linkevent(struct netxen_adapter *adapter, nx_fw_msg_t *msg) netdev->name, cable_len); } - netxen_advert_link_change(adapter, link_status); - /* update link parameters */ if (duplex == LINKEVENT_FULL_DUPLEX) adapter->link_duplex = DUPLEX_FULL; @@ -1447,6 +1445,8 @@ netxen_handle_linkevent(struct netxen_adapter *adapter, nx_fw_msg_t *msg) adapter->module_type = module; adapter->link_autoneg = autoneg; adapter->link_speed = link_speed; + + netxen_advert_link_change(adapter, link_status); } static void
First update the adapter variables with the current speed and mode before fire the notification. Otherwise, the get_settings() may provide old values. Signed-off-by: Flavio Leitner <fbl@redhat.com> --- drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)