From patchwork Tue Jul 10 00:09:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Mason X-Patchwork-Id: 169994 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 544BD2C0209 for ; Tue, 10 Jul 2012 10:09:49 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755207Ab2GJAJq (ORCPT ); Mon, 9 Jul 2012 20:09:46 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:56424 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755139Ab2GJAJo (ORCPT ); Mon, 9 Jul 2012 20:09:44 -0400 Received: by mail-pb0-f46.google.com with SMTP id rp8so20018595pbb.19 for ; Mon, 09 Jul 2012 17:09:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=4IwPY7uB8ZVVPm0fxvef15165lOh8+81z0ppi60wf9k=; b=FibwAGvaKYOHI34UpzUgk6OV4ql4oispUPD5MDMiXPvrpaVtaNuIi4BYhx2UhQnpyU IQ/uup7/6Tp2BgNbm0AR76I47L11pNDJ/4BdcFnmaHXn+69jKjFFoMMuWgrAwq22ih0O NT06iv0XZvwmvS8KEb4B3tYRV945/d6o7wvTWPt6oRbQftQqlvAqJaNn6uc8OqfdIRap YGSDX4SEWwwBTi4H5ArlVCWu0n7cECjij0fMkOel4wYBvc2EC6ThMK+rWoKxIU6dNQys 1siQ95D8Bn+qv4+K/8+nufTlMVZL2fCedScxzdRtyK/3P+31YZhYsNAabACIN7f6CzPg UYWQ== Received: by 10.68.194.169 with SMTP id hx9mr63950898pbc.8.1341878984261; Mon, 09 Jul 2012 17:09:44 -0700 (PDT) Received: from scylla (184-98-21-173.phnx.qwest.net. [184.98.21.173]) by mx.google.com with ESMTPS id pg3sm28660760pbc.2.2012.07.09.17.09.41 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Jul 2012 17:09:43 -0700 (PDT) Received: by scylla (sSMTP sendmail emulation); Mon, 09 Jul 2012 17:10:16 -0700 From: Jon Mason To: "David S. Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 09/11] sungem: remove unnecessary setting of skb->dev Date: Mon, 9 Jul 2012 17:09:33 -0700 Message-Id: <1341878975-10577-9-git-send-email-jdmason@kudzu.us> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> References: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> X-Gm-Message-State: ALoCoQkkFkI2e+ilbKpJx2O4FxK1fzOBQ/FM7eZZ0bjRRFHDMjQKNgt9HOJEPpK84fzUvc20QcYA Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org skb->dev is being unnecessarily set by the driver's skb alloc routine (which is called in init and during rx). It is already being set to the proper value when eth_type_trans is called on packet receive, and the skb->dev is not referenced anywhere else in the code. Signed-off-by: Jon Mason --- drivers/net/ethernet/sun/sungem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c index 3cf4ab7..9ae12d0 100644 --- a/drivers/net/ethernet/sun/sungem.c +++ b/drivers/net/ethernet/sun/sungem.c @@ -752,7 +752,6 @@ static __inline__ struct sk_buff *gem_alloc_skb(struct net_device *dev, int size if (likely(skb)) { unsigned long offset = ALIGNED_RX_SKB_ADDR(skb->data); skb_reserve(skb, offset); - skb->dev = dev; } return skb; }