From patchwork Tue Jul 10 00:09:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Mason X-Patchwork-Id: 169991 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BD3DD2C0205 for ; Tue, 10 Jul 2012 10:09:35 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755195Ab2GJAJc (ORCPT ); Mon, 9 Jul 2012 20:09:32 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:56424 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755180Ab2GJAJ3 (ORCPT ); Mon, 9 Jul 2012 20:09:29 -0400 Received: by mail-pb0-f46.google.com with SMTP id rp8so20018595pbb.19 for ; Mon, 09 Jul 2012 17:09:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=EO979QcsKJQfTkvApUotvTiYxF6A3nnTcg5jCjJ7LQE=; b=Zvg2Ijr6AHjH04QrWXuHeqCr/FMSDLwvlUPEbrMwCv2i5wwh/H7Rik6VboV+nKN3im xqJGW50tuE09Glyld9NJUJ9rGEzpgKtx+RPsbfUNNOXwmfGHayEaMqJQ12usO6UD0W/f QIQWfkBoCbaXNJBmeS7sDlYGiCdoncbhMGgoPzrwUh/w2vqDqlkrXqC9Xt/5l+Nocyqq G056CNkw0whrWyjTorOzbn63isNYv9niUHX8i36ZqYrr0SIdYahVeiJ9zY6Al11VLRqh 8CVObtq8AB5cs9jN7mDUAqNTyNVFQf1DqOhLzZgk+qi+3nrpXbT0Xpm+Xhgp3gKcJMKz QqaQ== Received: by 10.66.77.7 with SMTP id o7mr39221588paw.37.1341878969117; Mon, 09 Jul 2012 17:09:29 -0700 (PDT) Received: from scylla (184-98-21-173.phnx.qwest.net. [184.98.21.173]) by mx.google.com with ESMTPS id of4sm28636339pbb.51.2012.07.09.17.09.25 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Jul 2012 17:09:28 -0700 (PDT) Received: by scylla (sSMTP sendmail emulation); Mon, 09 Jul 2012 17:10:00 -0700 From: Jon Mason To: "David S. Miller" Cc: netdev@vger.kernel.org, Anirban Chakraborty , Sony Chacko , linux-driver@qlogic.com Subject: [PATCH 06/11] qlcnic: remove unnecessary setting of skb->dev Date: Mon, 9 Jul 2012 17:09:30 -0700 Message-Id: <1341878975-10577-6-git-send-email-jdmason@kudzu.us> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> References: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> X-Gm-Message-State: ALoCoQm2CMALt60hAypiC0LC3w6Bje4CDyyrZEqmJU/5MwEHSTWYAT3Pvq4Njl9bB3zAw+dqWEDl Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org skb->dev is being unnecessarily set before calling eth_type_trans. eth_type_trans already sets skb->dev to the proper value, thus making this unnecessary. Signed-off-by: Jon Mason Cc: Anirban Chakraborty Cc: Sony Chacko Cc: linux-driver@qlogic.com --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c index 8620b69..0bcda9c 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_init.c @@ -1488,8 +1488,6 @@ static struct sk_buff *qlcnic_process_rxbuf(struct qlcnic_adapter *adapter, skb_checksum_none_assert(skb); } - skb->dev = adapter->netdev; - buffer->skb = NULL; return skb;