From patchwork Tue Jul 10 00:09:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Mason X-Patchwork-Id: 169989 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9BD542C0205 for ; Tue, 10 Jul 2012 10:09:26 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755188Ab2GJAJX (ORCPT ); Mon, 9 Jul 2012 20:09:23 -0400 Received: from mail-gh0-f174.google.com ([209.85.160.174]:43517 "EHLO mail-gh0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755180Ab2GJAJT (ORCPT ); Mon, 9 Jul 2012 20:09:19 -0400 Received: by ghrr11 with SMTP id r11so10734572ghr.19 for ; Mon, 09 Jul 2012 17:09:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=ZiBlR01S7En9BrKEdnoGUdJ84piG+2X52X5vp3J3qPk=; b=X9gAin6T2qjEofJcoPkF9YMpwp/8G/Ooo8KMKCCdFswp3h73wPPmIQSHUcbXMAS/k8 I7HCbsy/3EADeJG757W6xeZK1tw0JH7zm/W1yPgjVHnOI0xjoK3fPwVih0VdH/khK1OP Q6O+J5p2aQoVmw1VOo37umXb+4uEyIE99D1wMMoQIxZNhzFE6+9fNEq4BCaImlBXfJZD yDUqt0l/TPvwW3NJphOmgnXZv/oKAziXPgnCYiwrRjQTFE10VyQIWTbNunEEVmCB4uOw QVrULaNYzUzEqnJTulUctGgGW4rDXoblmrvi2inwgEG/N2dp8oa+Hpc7ySYP6f+qmyaA Kq0g== Received: by 10.66.9.2 with SMTP id v2mr69212755paa.65.1341878958714; Mon, 09 Jul 2012 17:09:18 -0700 (PDT) Received: from scylla (184-98-21-173.phnx.qwest.net. [184.98.21.173]) by mx.google.com with ESMTPS id to1sm28663079pbc.27.2012.07.09.17.09.15 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 09 Jul 2012 17:09:17 -0700 (PDT) Received: by scylla (sSMTP sendmail emulation); Mon, 09 Jul 2012 17:09:50 -0700 From: Jon Mason To: "David S. Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 04/11] lantiq_etop: remove unnecessary setting of skb->dev Date: Mon, 9 Jul 2012 17:09:28 -0700 Message-Id: <1341878975-10577-4-git-send-email-jdmason@kudzu.us> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> References: <1341878975-10577-1-git-send-email-jdmason@kudzu.us> X-Gm-Message-State: ALoCoQn9NXcD5otZV7tg8dOAVIM/wQnosqRu7WaOv6uMNS8H1y2+SVV20B6JjFyJTXxyI/uRpokW Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org skb->dev is being unnecessarily set before calling eth_type_trans. eth_type_trans already sets skb->dev to the proper value, thus making this unnecessary. Signed-off-by: Jon Mason --- drivers/net/ethernet/lantiq_etop.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index 5dc9cbd..9fa39eb 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -149,7 +149,6 @@ ltq_etop_hw_receive(struct ltq_etop_chan *ch) spin_unlock_irqrestore(&priv->lock, flags); skb_put(skb, len); - skb->dev = ch->netdev; skb->protocol = eth_type_trans(skb, ch->netdev); netif_receive_skb(skb); }